Skip to content

[ENH] k-Means: Add normalization checkbox#4099

Merged
lanzagar merged 1 commit into
biolab:masterfrom
janezd:owkmeans-normalize
Oct 11, 2019
Merged

[ENH] k-Means: Add normalization checkbox#4099
lanzagar merged 1 commit into
biolab:masterfrom
janezd:owkmeans-normalize

Conversation

@janezd

@janezd janezd commented Oct 11, 2019

Copy link
Copy Markdown
Contributor
Issue

Fixes #4075.

Description of changes
  • Add normalization checkbox.
  • Fix tests
  • Remove obsolete argument processEvents
Includes
  • Code changes
  • Tests
  • Documentation

@codecov

codecov Bot commented Oct 11, 2019

Copy link
Copy Markdown

Codecov Report

Merging #4099 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4099      +/-   ##
==========================================
- Coverage   85.56%   85.56%   -0.01%     
==========================================
  Files         385      385              
  Lines       69220    69232      +12     
==========================================
+ Hits        59231    59240       +9     
- Misses       9989     9992       +3

self.send_signal(self.widget.Inputs.data, Table("housing"), wait=5000)
self.commit_and_wait()
widget.update_results()
# for housing dataset without normalization,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

without -> with ?

@lanzagar lanzagar changed the title OWKMeans: Add normalization checkbox [ENH] k-Means: Add normalization checkbox Oct 11, 2019
@janezd janezd force-pushed the owkmeans-normalize branch from 2cf6a3d to 02a35be Compare October 11, 2019 15:01
@lanzagar lanzagar merged commit 858113f into biolab:master Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

k-Means widget does not normalize numeric features

2 participants