[FIX] Feature Constructor: Compatibility with Python 3.8#4222
Merged
Conversation
Contributor
|
This seems to work fine on Py3.7. |
Codecov Report
@@ Coverage Diff @@
## master #4222 +/- ##
==========================================
- Coverage 85.95% 85.95% -0.01%
==========================================
Files 394 394
Lines 70164 70164
==========================================
- Hits 60310 60309 -1
- Misses 9854 9855 +1 |
Contributor
Author
|
@ales-erjavec can you check the code in case I missed something before we merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Feature Constructor did not work on Python 3.8 due to AST changes.
Description of changes
posonlyargsAs far as I can tell, this does not cause any problems on older versions of python and is silently ignored (always empty anyway).
Constant(which is replacingNum,Str, ...)