[ENH] PCA: Add a signal with original data + pca#4255
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4255 +/- ##
=========================================
+ Coverage 86.2% 86.2% +<.01%
=========================================
Files 396 396
Lines 70437 70460 +23
=========================================
+ Hits 60718 60738 +20
- Misses 9719 9722 +3 |
janezd
changed the title
janezd
force-pushed
the
pca-original-data
branch
from
7d680c7 to
a89c640
Compare
Contributor
|
Nice, separation of the signals and including principal components as meta features is a nice idea. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Closes #3801.
Description of changes
To maintain backward compatibility, this adds a new signal instead of adding the original data as metas (ugly, not done in other widgets) or moving components to metas (incompatible).
Includes