[ENH] OWDiscretize: data info displayed in status bar#4331
Merged
Conversation
aturanjanin
changed the title
Codecov Report
@@ Coverage Diff @@
## master #4331 +/- ##
=========================================
+ Coverage 86.68% 86.9% +0.22%
=========================================
Files 396 396
Lines 71510 71851 +341
=========================================
+ Hits 61988 62442 +454
+ Misses 9522 9409 -113 |
VesnaT
requested changes
Jan 14, 2020
|
|
||
| self._update_spin_positions() | ||
|
|
||
| self.info.set_output_summary(self.info.NoInput) |
Contributor
There was a problem hiding this comment.
When setting output summary, output default message (self.info.NoOutput) should be used.
| output = self.data.transform(domain) | ||
| self.info.set_output_summary(len(output)) | ||
| else: | ||
| self.info.set_output_summary(self.info.NoInput) |
aturanjanin
force-pushed
the
owdiscretize
branch
from
53d5415 to
52e9b39
Compare
VesnaT
approved these changes
Jan 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Display input and output data info in the status bar.
Includes