Skip to content

[ENH] Predictions: Update splitter on resize#4433

Merged
lanzagar merged 2 commits into
biolab:masterfrom
janezd:owpredictions-resize
Feb 20, 2020
Merged

[ENH] Predictions: Update splitter on resize#4433
lanzagar merged 2 commits into
biolab:masterfrom
janezd:owpredictions-resize

Conversation

@janezd
Copy link
Copy Markdown
Contributor

@janezd janezd commented Feb 17, 2020

Issue

Fixes #4430.

Fails (and will continue to fail) at coverage.

Description of changes

Update splitter on resize event.

Includes
  • Code changes
  • Tests
  • Documentation

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 17, 2020

Codecov Report

Merging #4433 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4433      +/-   ##
==========================================
- Coverage   87.47%   87.45%   -0.02%     
==========================================
  Files         405      405              
  Lines       74135    74137       +2     
==========================================
- Hits        64846    64840       -6     
- Misses       9289     9297       +8     

@ajdapretnar
Copy link
Copy Markdown
Contributor

I personally love this fix, but a few more people should probably agree this is the desired behaviour. @markotoplak @lanzagar @PrimozGodec

@lanzagar
Copy link
Copy Markdown
Contributor

I definitely think it is better than before.
But in the (rare?) case when the splitter is manually changed I find the abrupt jump on resize a bit jarring. Maybe it would be best to keep the left size constant on resizes and stretch/shrink just the data view? Not sure if that complicates the implementation?

@janezd
Copy link
Copy Markdown
Contributor Author

janezd commented Feb 19, 2020

Maybe it would be best to keep the left size constant on resizes and stretch/shrink just the data view?

Would this be OK?

  • When the left part is changed, the splitter would reset to fit the left side. (Like it does now on resize.)
  • The user can manually move it.
  • When the window is resized, the left side would keep the same (no matter whether it was set automatically or by the user).

@janezd janezd force-pushed the owpredictions-resize branch from ffb61b5 to 9157ebd Compare February 19, 2020 20:58
@janezd
Copy link
Copy Markdown
Contributor Author

janezd commented Feb 20, 2020

I changed it as described above.

@lanzagar
Copy link
Copy Markdown
Contributor

👍

@lanzagar lanzagar merged commit 8d6dafa into biolab:master Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Predictions: smarter resizing

3 participants