Skip to content

[FIX] OWScatterPlotBase: Reset view before labels update #4907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
janezd merged 2 commits into from
Jul 31, 2020
Merged

[FIX] OWScatterPlotBase: Reset view before labels update #4907

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
294edee
OWScatterPlotBase: Reset view before labels update
VesnaT Jul 17, 2020
7ea4d2e
OWScatterPlotBase: Fix test for label position
janezd Jul 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Orange/widgets/visualize/owscatterplotgraph.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -834,6 +834,8 @@ def update_coordinates(self):
x, y = self.get_coordinates()
if x is None or len(x) == 0:
return

self._reset_view(x, y)
if self.scatterplot_item is None:
if self.sample_indices is None:
indices = np.arange(self.n_valid)
Expand All @@ -851,7 +853,6 @@ def update_coordinates(self):
self.update_labels()

self.update_density() # Todo: doesn't work: try MDS with density on
self._reset_view(x, y)

# Sizes
def get_sizes(self):
Expand Down
4 changes: 2 additions & 2 deletions Orange/widgets/visualize/tests/test_owscatterplotbase.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,9 +114,9 @@ def test_update_coordinates_and_labels(self):
xy[0][0] = 1.5
graph.update_coordinates()
self.assertEqual(graph.labels[0].pos().x(), 1.5)
xy[0][0] = 0 # This label goes out of the range
xy[0][0] = 0 # This label goes out of the range; reset puts it back
graph.update_coordinates()
self.assertEqual(graph.labels[0].pos().x(), 2)
self.assertEqual(graph.labels[0].pos().x(), 0)

def test_update_coordinates_and_density(self):
graph = self.graph
Expand Down