Skip to content

[FIX] Scatter plot: Fix rotation of regression line label#5840

Merged
ajdapretnar merged 1 commit into
biolab:masterfrom
janezd:scatteplot-proper-labels
Feb 18, 2022
Merged

[FIX] Scatter plot: Fix rotation of regression line label#5840
ajdapretnar merged 1 commit into
biolab:masterfrom
janezd:scatteplot-proper-labels

Conversation

@janezd
Copy link
Copy Markdown
Contributor

@janezd janezd commented Feb 12, 2022

Issue

Fixes #5721.

I've no idea why I though this needs to be rotated. It's been four years; perhaps something changed in pyqtgraph?

Description of changes

Remove rotation.

Includes
  • Code changes

@dml5064
Copy link
Copy Markdown

dml5064 commented Feb 12, 2022

Issue

Fixes #5721.

I've no idea why I though this needs to be rotated. It's been four years; perhaps something changed in pyqtgraph?

Description of changes

Remove rotation.

Includes
  • Code changes

Oh yes I have seen this too. I think when it is a negative relationship...

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 12, 2022

Codecov Report

Merging #5840 (4c34372) into master (d545b38) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #5840   +/-   ##
=======================================
  Coverage   86.20%   86.20%           
=======================================
  Files         316      316           
  Lines       66615    66625   +10     
=======================================
+ Hits        57427    57437   +10     
  Misses       9188     9188           

@ajdapretnar
Copy link
Copy Markdown
Contributor

Tested on pyqtgraph==0.12.3. Even with negative correlation it was not reversed. Tried iris, housing, heart-disease. From this, I will assume it works.

@ajdapretnar ajdapretnar merged commit baef1d9 into biolab:master Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Negative regressions are printed upside-down

3 participants