[FIX] Fix failing tests on Python 3.11.8 on Windows#6737
Merged
Conversation
4a265d0 to
3bb11f6
Compare
3bb11f6 to
7a6cbe7
Compare
Contributor
Author
|
It seems that closing is not working in openpyxl as it worked in older versions of Python. I reported it: https://foss.heptapod.net/openpyxl/openpyxl/-/issues/2149 |
02a9dea to
8f7aa0b
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #6737 +/- ##
==========================================
- Coverage 88.13% 88.10% -0.04%
==========================================
Files 322 323 +1
Lines 70589 70670 +81
==========================================
+ Hits 62216 62264 +48
- Misses 8373 8406 +33 |
23b5fee to
8b892ab
Compare
Contributor
Author
|
/rebase |
5393b08 to
24a5198
Compare
Member
|
Here, you monkey patch ExcelReader. Does this code need to be in If possible, I'd also rather import it where the reader is implemented (of course, it that does not work, forget it). |
a2f8d2d to
6026fe9
Compare
Contributor
Author
|
@markotoplak, I changed it such that it is patched on the place it is used. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Recently, some tests started to fail on Windows. The issue is that Actions upgraded the Python 3.11 version to 3.11.8, which was released two weeks ago. The issue is caused by openpyxl and is fixed here: https://foss.heptapod.net/openpyxl/openpyxl/-/merge_requests/436.
Description of changes
Since it seems it will take a long for openpyxl to make a release I am making a temporary (ugly) patch here. This method is a copy of the fixed method from openpyxl).
Includes