Skip to content

[FIX] Fix error bars for threshold averaged ROC curves#7014

Merged
janezd merged 1 commit into
biolab:masterfrom
cjgunnar:fix-threshold-average-error-bars
Feb 7, 2025
Merged

[FIX] Fix error bars for threshold averaged ROC curves#7014
janezd merged 1 commit into
biolab:masterfrom
cjgunnar:fix-threshold-average-error-bars

Conversation

@cjgunnar
Copy link
Copy Markdown
Contributor

Issue

Fixes #7013

Description of changes

Fix typo causing incorrect error bars for threshold averaged ROC curves.

For functions roc_curve_threshold_average and roc_curve_thresh_avg_interp in ROC Analysis widget

Includes
  • Code changes
  • Tests
  • Documentation

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jan 31, 2025

CLA assistant check
All committers have signed the CLA.

@markotoplak markotoplak changed the title fix threshold average tpr_std [FIX] Fix error bars for threshold averaged ROC curves Feb 5, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.48%. Comparing base (091e88c) to head (521d623).
Report is 65 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7014      +/-   ##
==========================================
- Coverage   88.48%   88.48%   -0.01%     
==========================================
  Files         332      332              
  Lines       73333    73333              
==========================================
- Hits        64889    64886       -3     
- Misses       8444     8447       +3     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@janezd janezd self-assigned this Feb 7, 2025
@janezd
Copy link
Copy Markdown
Contributor

janezd commented Feb 7, 2025

Thanks for noticing, reporting and fixing!

This code is from 2014, but it was migrated from Orange 2, so the bug has likely been here for some 20 years.

@janezd janezd merged commit 70285e3 into biolab:master Feb 7, 2025
@cjgunnar cjgunnar deleted the fix-threshold-average-error-bars branch February 9, 2025 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Threshold Averaged ROC plot error bars are incorrect

3 participants