Skip to content

[FIX] Make ReliefF and RReliefF results replicable#7026

Merged
janezd merged 1 commit into
biolab:masterfrom
markotoplak:relief-replicable-by-default
Feb 14, 2025
Merged

[FIX] Make ReliefF and RReliefF results replicable#7026
janezd merged 1 commit into
biolab:masterfrom
markotoplak:relief-replicable-by-default

Conversation

@markotoplak
Copy link
Copy Markdown
Member

Issue

ReliefF and RReliefF had default random_seed set to None. Therefore their results in Rank and Preprocess widgets could differ. I became aware of this when reviewing #7023.

Description of changes

I just changed the default random_seed, so now ReliefF is replicable unless explicitly specified not to be.

It would be trivial to add random_seed arguments in some places, but the Rank and Preprocess would need slightly bigger refactoring, because the current code there does not allow easy adding of arguments to various scorers.

Includes
  • Code changes
  • Tests
  • Documentation

@markotoplak markotoplak force-pushed the relief-replicable-by-default branch from 4552268 to 041ff6d Compare February 12, 2025 10:57
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.36%. Comparing base (e67650f) to head (041ff6d).
Report is 42 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7026      +/-   ##
==========================================
- Coverage   88.36%   88.36%   -0.01%     
==========================================
  Files         332      332              
  Lines       73345    73345              
==========================================
- Hits        64814    64812       -2     
- Misses       8531     8533       +2     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@janezd janezd self-assigned this Feb 14, 2025
@janezd janezd merged commit 0d9bdcc into biolab:master Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants