Skip to content

Change sim fov #683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

val-ba
Copy link
Contributor

@val-ba val-ba commented Mar 27, 2025

Summary

Should fix #497
This is based on the jazzy dev branch though.

Proposed changes

Change fov in wolfgang.proto from 1.04 to 1.517

Related issues

Checklist

  • Run colcon build
  • Write documentation
  • Test on your machine
  • Test on the robot
  • Create issues for future work
  • Triage this PR and label it

val-ba and others added 30 commits November 15, 2024 13:04
which was not held consistent with the `robot.urdf` joint limits
Co-authored-by: David Nguyen <[email protected]>
Co-authored-by: Pär <[email protected]>
Co-authored-by: Helena Jäger <[email protected]>
Co-authored-by: Lea <[email protected]>
Co-authored-by: Pär Wiegmann <[email protected]>
@github-project-automation github-project-automation bot moved this to 🆕 New in Software Mar 27, 2025
@val-ba val-ba requested review from Flova, jaagut and texhnolyze March 27, 2025 11:10
@val-ba val-ba moved this from 🆕 New to 👀 In review in Software Mar 27, 2025
@val-ba val-ba self-assigned this Mar 27, 2025
@Flova
Copy link
Member

Flova commented Mar 27, 2025

I think you might have used the wrong base branch. There are a lot of changes here

@val-ba val-ba changed the base branch from main to feature/jazzy-ubuntu2404-devcontainer March 27, 2025 11:13
@texhnolyze texhnolyze force-pushed the feature/jazzy-ubuntu2404-devcontainer branch from 2860b1a to d9191c6 Compare March 27, 2025 11:14
@val-ba val-ba closed this Mar 27, 2025
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Software Mar 27, 2025
@val-ba val-ba deleted the fix/change_sim_FOV branch March 27, 2025 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Camera FOV in simulation differs from real world.
9 participants