Skip to content

Added – Turkish Language v1.0#853

Open
zackha wants to merge 10 commits into
bitcoin-core:masterfrom
zackha:stable
Open

Added – Turkish Language v1.0#853
zackha wants to merge 10 commits into
bitcoin-core:masterfrom
zackha:stable

Conversation

@zackha

@zackha zackha commented Jan 18, 2022

Copy link
Copy Markdown

Added – Turkish language option has been added and all pages have been translated into Turkish. ( 26dcc32 )

Comment thread _data/languages.yml Outdated
zh_TW: 繁體中文
ja: 日本語
es: Español
tr: Turkish No newline at end of file

This comment was marked as off-topic.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep türkçe (eng: Turkish)

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. the word has been replaced with its own language (5c8082c)

Comment thread _data/navigation.yml Outdated
releases:
title: "Versiyonlar"
url: "/tr/releases/"
faq:

This comment was marked as off-topic.

@zackha zackha Jan 18, 2022

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the code you show is releases, not FAQ

This comment was marked as off-topic.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FAQ I'm postponing for now. If there is a fix, change or improvement you want, feel free to point it out. 👍

@zackha zackha left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix – bitcoin core logo aligned to menu by sick of symmetry (d8074a0)

The property that is not in .scss lang has been removed.
@zackha zackha changed the title added – turkish language v1 added – turkish language and a few fixes v1 Jan 18, 2022
@katesalazar

This comment was marked as off-topic.

Comment thread _data/languages.yml Outdated
zh_TW: 繁體中文
ja: 日本語
es: Español
tr: Turkish No newline at end of file

This comment was marked as off-topic.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh of course 🤦‍♂️

@zackha

zackha commented Jan 18, 2022

Copy link
Copy Markdown
Author

Fix – bitcoin core logo aligned to menu by sick of symmetry (d8074a0)

Not really opposed, but mind your change from responsive. Have you tested well different page widths?

Tested in different widths in responsive browser not found any glitch.

The word Turkish has been replaced with its turkish equivalent (Türkçe).
@katesalazar

This comment was marked as off-topic.

@zackha

zackha commented Jan 18, 2022

Copy link
Copy Markdown
Author

...

Not really opposed, but mind your change from responsive. Have you tested well different page widths?

Tested in different widths in responsive browser and found not found any glitch.

Does the pic in div.site-name look good when li#langselect overflows to the second row, under the "About" li? In my browser that's a questionable alignment. It's the only width that I've found worse for your change, though.

I think this looks better when we compare it to the old one. But much better, I can provide a professional touch with fully responsive.

The change will be made more professional.
pgp_key_fingerprint: "PGP anahtar parmak izi"
verify_download: "İndirmenizi doğrulayın"

verification_recommended: >

This comment was marked as off-topic.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Download page completely translated in Turkish language (131d121)

This comment was marked as off-topic.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely 🤗

This comment was marked as off-topic.

Comment thread _sass/page.scss
a {
display: block;
padding: 10px 0;
decoration: none;

This comment was marked as off-topic.

@zackha zackha Jan 19, 2022

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The property (decoration) that is not in .css lang has been removed. I don't know why it was added either. (see. https://www.w3schools.com/cssref/)

@katesalazar katesalazar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept ACK,
only the Downloads page is preventing me full ACK.
Can't see the untranslated paragraphs displayed in the rendered page.
Dunno why they seemed to vanish.

@zackha zackha closed this Jan 19, 2022
@zackha zackha deleted the stable branch January 19, 2022 07:13
@zackha zackha restored the stable branch January 19, 2022 07:14
@zackha

zackha commented Jan 19, 2022

Copy link
Copy Markdown
Author

Concept ACK, only the Downloads page is preventing me full ACK. Can't see the untranslated paragraphs displayed in the rendered page. Dunno why they seemed to vanish.

Same problem in Japanese. Now, with a new update, I am making the whole page completely in Turkish, like English and Spanish. Wait for the update.

@zackha zackha reopened this Jan 19, 2022
@zackha

zackha commented Jan 19, 2022

Copy link
Copy Markdown
Author

Concept ACK, only the Downloads page is preventing me full ACK. Can't see the untranslated paragraphs displayed in the rendered page. Dunno why they seemed to vanish.

Download page completely translated in Turkish language (131d121)

Comment thread _posts/tr/pages/2016-01-01-about.md Outdated
type: pages
layout: page
lang: tr
version: 1

This comment was marked as off-topic.

@zackha zackha Jan 19, 2022

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was replaced with the version number of the English language version that I translated. (118a8de)

This comment was marked as off-topic.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5 does not exist for this document, last is version 3, see:

It was replaced with the version number of the English language version that I translated. (118a8de)

@zackha

zackha commented Jan 19, 2022

Copy link
Copy Markdown
Author

why did you change this? (it was previously wrongly at 1)

The original is version 5 in the English document. I converted it from version 5.

@katesalazar

This comment was marked as off-topic.

@zackha

zackha commented Jan 19, 2022

Copy link
Copy Markdown
Author

I still don't understand why remove line:

decoration: none;

otherwise, ACK 2508deb

Because there is no property named decoration in .css Its absence does not constitute a deficiency. Current css renderers suggest a fix to the decoration property. (see. https://www.w3schools.com/cssref/)

@katesalazar

This comment was marked as off-topic.

@zackha

zackha commented Jan 19, 2022

Copy link
Copy Markdown
Author

Great, thanks.

ACK 2508deb

Thanks!

You're welcome! I will update the header section next.

@zackha zackha changed the title added – turkish language and a few fixes v1 Added – Turkish Language v1.0 Jan 23, 2022
Comment thread _data/navigation.yml Outdated
title: "Versiyonlar"
url: "/tr/releases/"
faq:
title: "FAQs"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was removed

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the info, I'll revise it now...

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Removed faq nav (8985a37)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants