Rename Block Clock to Block Status #441
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarnixCroes
reviewed
Jan 21, 2025
Contributor
MarnixCroes
left a comment
MarnixCroes
left a comment
There was a problem hiding this comment.
build fails
make[1]: *** No rule to make target 'qml/components/blockclockdial.cpp', needed by 'qml/components/qt_libbitcoinqt_a-blockclockdial.o'. Stop.
Contributor
|
here still mentioned? and in |
Contributor
pablomartin4btc
left a comment
pablomartin4btc
left a comment
There was a problem hiding this comment.
ACK on removing "Clock".
Just thinking it loud, shouldn't be more like "Sync" status? (moreover to avoid confusion with an individual block status).
Also found this in current QT desktop app source (src/qt/clientmodel.h):
enum class SyncType {
HEADER_PRESYNC,
HEADER_SYNC,
BLOCK_SYNC
};
Maybe we need something like that later to identify on which sync we are...
Member
|
Needs rebase. |
Member
|
Closing for now. Feel free to reopen this based on the new default branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes rename all instances of "Block Clock" to "Block Status" under the qml directory.