Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: build RPC image automagically #301

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

willcl-ark
Copy link
Contributor

@willcl-ark willcl-ark commented Mar 5, 2024

This will build a warnet-rpc image when merging into main branch

@willcl-ark
Copy link
Contributor Author

I hate workflows

@willcl-ark
Copy link
Contributor Author

Ok this does work, but currently it will just push a new "latest" tag when we merge things into main branch, see here for example.

I wanted to have each pr get it's own tag, but thats difficult when PRs come from forks (you have to use a GitHub "environment", and I cannot get it to read secrets out of the environment correctly).

@willcl-ark willcl-ark merged commit 0d652fb into bitcoin-dev-project:main Mar 5, 2024
10 of 11 checks passed
@willcl-ark willcl-ark deleted the build-rpc-action branch March 5, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

1 participant