Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust cli #327

Closed
wants to merge 34 commits into from
Closed

Rust cli #327

wants to merge 34 commits into from

Conversation

willcl-ark
Copy link
Contributor

@willcl-ark willcl-ark commented Mar 29, 2024

  • Commands implemented except graph validate are working. Converting an xml graphml file to json seems to be a bit of a pain for validation
  • added a --rust_cli matrix to tests on rpc tests, which will (lightly) test the new tool
  • pretty print warnet table repr in network start command
  • quickxml-to-serde pulls in a different xml lib than we use xmltree, could possibly use the same as them?
  • implement the image commands
  • write some tests
  • @pinheadmz slightly scary-looking graph import-json not implemented yet.

Notes:

  • Graphs are generated with some kind of randomness in the tagging, which looks weird, but works fine.

@willcl-ark willcl-ark force-pushed the rust-cli branch 5 times, most recently from 326f919 to 87bc5f4 Compare March 29, 2024 16:53
@willcl-ark willcl-ark marked this pull request as ready for review March 29, 2024 21:52
@willcl-ark
Copy link
Contributor Author

I think if it made sense, we could perhaps strip out deps on jsonrpsee and tokio, and use a more rdimentary JSONRPC client, possibly something more like this: https://github.com/apoelstra/rust-jsonrpc

@willcl-ark
Copy link
Contributor Author

Closing for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

1 participant