user auth: check for None, replace with [] #700
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mplsgrant
changed the title
|
LGTM @satsie if you're able to reproduce the issue again (resetting that stub kubeconfig file?) and verify this PR fixes the issue that would be really great. Either way we should merge this and cut a release before the MIT event this week. |
macgyver13
reviewed
Mar 30, 2025
src/warnet/users.py
Outdated
| @@ -41,6 +41,8 @@ def auth(auth_config): | |||
| if not is_first_config: | |||
| for category in ["clusters", "users", "contexts"]: | |||
| if category in auth_config: | |||
| if not base_config[category]: | |||
There was a problem hiding this comment.
This will generate a KeyError exception if category is not in base_config right?
if category in base_config and not base_config[category] should work
There was a problem hiding this comment.
Nice! That works smoothly. Thank you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check for None in kubeconfig and replace it with [] in order to avoid #699