Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update image build for cmake #702

Merged
merged 1 commit into from
Mar 29, 2025

Conversation

willcl-ark
Copy link
Contributor

Addresses #701

You can build a commit with e.g.

warnet image build --repo bitcoin/bitcoin --commit-sha d6db87165c6dc2123a759c79ec236ea1ed90c0e3 --registry bitcoindevproject --tags v29.0rc2 --arches amd64

@pinheadmz
Copy link
Contributor

Works! thank you.
built: https://hub.docker.com/repository/docker/bitcoindevproject/bitcoin/tags/v29.0-rc2/sha256-6df688b17fe8f47845c57d35aaacb63c9bff6260ec5c439f07a6841825c03491

using: warnet image build --repo bitcoin/bitcoin --commit-sha d6db87165c6dc2123a759c79ec236ea1ed90c0e3 --registry bitcoindevproject/bitcoin --tags bitcoindevproject/bitcoin:v29.0-rc2 --action push

One note though, for a follow up: what does docker_registry do? doesn't look used. also could use a more robust help comment for click.

@pinheadmz pinheadmz merged commit 4d11ce3 into bitcoin-dev-project:main Mar 29, 2025
21 of 30 checks passed
@willcl-ark willcl-ark mentioned this pull request Mar 31, 2025
@willcl-ark
Copy link
Contributor Author

Opened #703 to address feedback :)

@willcl-ark willcl-ark deleted the image-build-cmake branch March 31, 2025 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants