Skip to content

docs(wallet): provide guidance on use of ChangeSet#198

Merged
notmandatory merged 1 commit intobitcoindevkit:masterfrom
ValuedMammal:doc/changeset
May 9, 2025
Merged

docs(wallet): provide guidance on use of ChangeSet#198
notmandatory merged 1 commit intobitcoindevkit:masterfrom
ValuedMammal:doc/changeset

Conversation

@ValuedMammal
Copy link
Copy Markdown
Collaborator

This work in progress PR is meant to expand on and clarify the documentation for bdk_wallet::ChangeSet.

fixes #9

Changelog notice

TBD

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@ValuedMammal ValuedMammal added the documentation Improvements or additions to documentation label Apr 8, 2025
@ValuedMammal ValuedMammal added this to the 1.3.0 milestone Apr 8, 2025
@ValuedMammal ValuedMammal self-assigned this Apr 8, 2025
@ValuedMammal ValuedMammal moved this to Discussion in BDK Wallet Apr 8, 2025
@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 14323414626

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 86.525%

Totals Coverage Status
Change from base Build 14270666930: 0.0%
Covered Lines: 7269
Relevant Lines: 8401

💛 - Coveralls

Copy link
Copy Markdown
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 43b6725

Thanks for the very detailed description of this critical struct.

@notmandatory notmandatory merged commit 7cdc985 into bitcoindevkit:master May 9, 2025
14 checks passed
@github-project-automation github-project-automation bot moved this from Needs Review to Done in BDK Wallet May 9, 2025
@thunderbiscuit
Copy link
Copy Markdown
Member

That's so awesome! Thanks a bunch. 😎

@ValuedMammal ValuedMammal deleted the doc/changeset branch May 10, 2025 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Improve docs on ChangeSet persistence requirements

4 participants