test: add comprehensive tests for bip66, merkle, and push_data modules#2315
Open
amussara wants to merge 1 commit intobitcoinjs:masterfrom
Open
test: add comprehensive tests for bip66, merkle, and push_data modules#2315amussara wants to merge 1 commit intobitcoinjs:masterfrom
amussara wants to merge 1 commit intobitcoinjs:masterfrom
Conversation
Add test coverage for three modules that previously had no dedicated test files: - bip66.spec.ts: 41 tests covering DER signature check/decode/encode, including edge cases for invalid lengths, negative values, excessive padding, and encode-decode roundtrips - merkle.spec.ts: 10 tests covering fastMerkleRoot with empty arrays, single elements, odd/even counts, determinism, and order sensitivity - push_data.spec.ts: 24 tests covering encodingLength, encode, and decode for all OP_PUSHDATA variants (1/2/4), offset handling, buffer boundary checks, and encode-decode roundtrips
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add test coverage for three modules that previously had no dedicated test files: