Localize user facing strings#814
Conversation
Move Rust-facing UI copy to typed states and render user-visible text through native iOS and Android localization resources. Add platform mappings for Rust alerts and errors, localize existing flows, and update generated UniFFI bindings for the typed API changes.
Replace remaining Rust string payloads in exported UI state with typed values that native iOS and Android code can render through localization resources. Update generated bindings, platform call sites, and focused tests for the typed state changes.
Refactors send-flow and wallet actor error surfaces to use typed variants without embedded strings across Rust, UniFFI-generated Swift/Kotlin bindings, and mobile handlers. Detailed failure context is now logged in Rust (`warn!`) instead of serialized through FFI, unknown wallet actor errors are reduced to a payload-free reconcile message, and insufficient-funds handling now maps directly to `SendFlowError::InsufficientFunds` so Android/iOS custom fee flows catch the correct error variant.
|
Too many files changed for review. ( Bypass the limit by tagging |
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 244099031a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| error => { | ||
| warn!("Wallet manager send flow error: {error}"); | ||
| Self::WalletManager |
There was a problem hiding this comment.
When the wallet actor returns WalletManagerError::LockedOutputsSelected for a manual/coin-control transaction whose selected outpoints include a locked coin, this catch-all collapses it into SendFlowError::WalletManager. The frontends no longer receive the original wallet-manager variant that they previously special-cased, so users get a generic wallet-operation error instead of being told to unlock the coin or choose different coins; map this variant to a specific send-flow error before the catch-all.
Useful? React with 👍 / 👎.
1 participant
No description provided.