Cutoff layout issues#816
Open
praveenperera wants to merge 10 commits into
Open
Conversation
📝 WalkthroughWalkthroughThis PR adds Android and iOS UI layout-regression/audit test suites with screenshot capture and viewport-fit assertions, applies Compose test tags and layout refactors (BoxWithConstraints scrolling) across several Android screens, applies GeometryReader-driven scrollable layout decisions across many iOS screens, tweaks onboarding hero icon sizing/previews on both platforms, and introduces device "stay-awake" tooling for Android instrumentation tests via a shared test rule and new xtask CLI commands. ChangesAndroid Compose Layout Audit Testing
Estimated code review effort: 4 (Complex) | ~70 minutes iOS Responsive Layout Refactor and Layout Tests
Estimated code review effort: 4 (Complex) | ~75 minutes Android Device Stay-Awake Tooling
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)sequenceDiagram
participant Just as justfile
participant Xtask as xtask CLI
participant Guard as AndroidStayAwakeGuard
participant Adb as adb
Just->>Xtask: android-ui-manual / android-stay-awake
Xtask->>Adb: read stay_on_while_plugged_in, screen_off_timeout
Xtask->>Adb: apply stay-awake settings, dismiss keyguard
Xtask->>Xtask: run_manual_ui_tests / run command
Xtask->>Guard: restore settings on drop
Guard->>Adb: restore prior settings
sequenceDiagram
participant Test as AndroidCompactLayoutAuditTest
participant Compose as ComposeContentTestRule
participant Screenshot as LayoutScreenshot
participant Assert as assertNodeInsideViewport
Test->>Compose: renderCompact(screenName, content)
Test->>Compose: scroll to bottom-tagged node
Test->>Screenshot: saveNodeScreenshotToLayoutAudit(tag, name)
Test->>Assert: check node bounds vs viewport
Assert-->>Test: pass/fail on fit
Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR fixes compact-screen layout cutoffs across the mobile app. The main changes are:
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (4): Last reviewed commit: "Refine layout test helpers and detekt ru..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
praveenperera
force-pushed
the
cutoff-layout-issues
branch
from
c518dd7 to
f4d2441
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 8
🧹 Nitpick comments (4)
android/app/src/main/java/org/bitcoinppl/cove/flows/OnboardingFlow/OnboardingCloudRestorePromptViews.kt (1)
371-372: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winDuplicate magic value across files for hero inner-circle sizing.
innerRingSize = 68.dphere duplicatesinnerBadgeSize = 68.dpintroduced independently inOnboardingTheme.kt(OnboardingStatusHero). Both hero composables now hardcode the same value in two places; if one is tuned later the other can silently drift out of sync. The iOS counterpart (OnboardingRecoveryTheme.swift) centralizes a singleinnerBadgeSizefor this purpose.Consider hoisting a shared constant (e.g., in
OnboardingTheme.kt) that bothOnboardingCloudSearchHeroandOnboardingStatusHeroreference.Also applies to: 394-394
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@android/app/src/main/java/org/bitcoinppl/cove/flows/OnboardingFlow/OnboardingCloudRestorePromptViews.kt` around lines 371 - 372, The hero inner-circle size is hardcoded twice, causing duplicated magic values between OnboardingCloudSearchHero and OnboardingStatusHero. Hoist the shared 68.dp value into a single reusable constant in OnboardingTheme.kt (for example alongside OnboardingStatusHero’s existing innerBadgeSize) and update OnboardingCloudRestorePromptViews.kt to reference that constant so both composables stay in sync.android/app/src/androidTest/java/org/bitcoinppl/cove/flows/NewWalletFlow/hot_wallet/HotWalletCreateScreenTest.kt (1)
118-147: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winConsider extracting shared viewport/screenshot-mode helpers.
auditViewportWidth(),auditViewportHeight(), andscreenshotMode()duplicate the viewport-sizing pattern used inAndroidCompactLayoutAuditTest.kt(e.g. itsauditViewportHeight()usage). As more per-screen layout tests are added to this suite, keeping this logic in one place (e.g.test/LayoutScreenshot.ktor a newtest/LayoutViewport.kt) would prevent divergence between test files.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@android/app/src/androidTest/java/org/bitcoinppl/cove/flows/NewWalletFlow/hot_wallet/HotWalletCreateScreenTest.kt` around lines 118 - 147, Extract the repeated viewport/screenshot argument parsing from HotWalletCreateScreenTest’s screenshotMode(), auditViewportWidth(), auditViewportHeight(), and saveViewportScreenshot() into a shared test helper so it matches the pattern already used by AndroidCompactLayoutAuditTest. Create or reuse a central utility such as test/LayoutScreenshot.kt or test/LayoutViewport.kt, then update this test to call the shared helper methods instead of duplicating the InstrumentationRegistry argument parsing and default viewport values.ios/Cove/Flows/NewWalletFlow/NewWalletSelectScreen.swift (1)
38-53: 📐 Maintainability & Code Quality | 🔵 Trivial | 🏗️ Heavy liftRepeated GeometryReader/scroll-decision boilerplate across screens.
The
GeometryReader→scrollableLayout→ScrollView(mainContent)vsbottomActionLayout()scaffolding, plususesScrollableLayout, is duplicated nearly verbatim across this file,HotWalletSelectScreen.swift,TapSignerAdvancedChainCode.swift, andTapSignerChooseChainCode.swift(and reportedly more screens per the PR description). Consider extracting a sharedViewModifier/generic container (e.g.ScrollableOrFixedLayout<Content>) that takes the scroll-decision closure and content builders, to reduce copy-paste drift risk (as already seen with the height-threshold inconsistency above).Also applies to: 107-233
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ios/Cove/Flows/NewWalletFlow/NewWalletSelectScreen.swift` around lines 38 - 53, The GeometryReader-based scroll vs fixed-layout decision is duplicated in NewWalletSelectScreen’s main layout and across the related select screens, so extract it into a shared reusable container or ViewModifier (for example, a generic ScrollableOrFixedLayout) that owns the available-height check and the ScrollView vs bottomActionLayout branching. Update the existing uses of usesScrollableLayout, mainContent, and bottomActionLayout to route through that shared helper so the threshold logic and sizing behavior live in one place and stay consistent.ios/Cove/Flows/NewWalletFlow/HotWallet/VerifyWords/VerificationCompleteScreen.swift (1)
12-12: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winReplace
sizeCategorywithdynamicTypeSize.@Environment(\.sizeCategory)is deprecated; use@Environment(\.dynamicTypeSize)here and compare against.xxLarge.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ios/Cove/Flows/NewWalletFlow/HotWallet/VerifyWords/VerificationCompleteScreen.swift` at line 12, Replace the deprecated sizeCategory environment usage in VerificationCompleteScreen with dynamicTypeSize. Update the environment property on the view to use `@Environment`(\.dynamicTypeSize), and adjust any size checks in the same screen to compare against .xxLarge instead of the old UIContentSizeCategory-based value.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@android/app/src/main/java/org/bitcoinppl/cove/flows/SendFlow/SendFlowConfirmScreen.kt`:
- Around line 158-210: The scrollable Column in SendFlowConfirmScreen is using a
weighted Spacer, which is invalid inside verticalScroll and can crash during
measurement. Remove Spacer(Modifier.weight(1f)) from the Column in
SendFlowConfirmScreen and use a non-weight layout approach instead, such as
arranging the content with verticalArrangement or inserting a fixed-size Spacer.
Keep the existing AmountWidget, SummaryWidget, and SwipeToSendStub structure
intact while adjusting the Column layout so it no longer relies on weight inside
the scroll container.
In `@ios/Cove/Flows/NewWalletFlow/HotWallet/HotWalletCreateScreen.swift`:
- Around line 38-90: The layout breakpoint check is duplicated in
HotWalletCreateScreen’s usesScrollableLayout and the same threshold logic
appears in several other wallet/onboarding views, so centralize it in a shared
helper instead of keeping the hardcoded sizeCategory and 812 comparison inline.
Add a reusable method or GeometryProxy extension such as
usesCompactLayout(sizeCategory:) and update HotWalletCreateScreen.body to call
it, then migrate the matching threshold logic in the other screens to the same
helper so future breakpoint changes happen in one place.
In `@ios/Cove/Flows/NewWalletFlow/HotWallet/HotWalletSelectScreen.swift`:
- Around line 163-165: The usesScrollableLayout(availableHeight:) logic in
HotWalletSelectScreen currently ignores availableHeight and relies only on
sizeCategory, which can keep the fixed layout on compact-height devices. Update
that method to combine the Dynamic Type check with the compact-height fallback,
matching the existing sizeCategory >= .extraExtraLarge || availableHeight <= 812
pattern so small devices still switch to the scrollable layout.
In
`@ios/Cove/Flows/NewWalletFlow/HotWallet/VerifyWords/VerificationCompleteScreen.swift`:
- Around line 115-118: The usesScrollableLayout(availableHeight:) helper is
duplicated with the same 812 threshold across VerificationCompleteScreen and the
related wallet screens, so extract it into a shared helper instead of keeping
per-screen copies. Move the logic into a common location such as a View
extension (or another shared utility) that takes sizeCategory and
availableHeight, then update VerificationCompleteScreen, VerifyWordsScreen,
SecretWordsScreen, HotWalletCreateScreen, HotWalletSelectScreen, and
NewWalletSelectScreen to call the shared implementation.
In `@ios/Cove/Flows/Onboarding/StartupRecovery/DeviceRestoreView.swift`:
- Around line 121-123: The restoringHeroIcon helper is currently using the
default static OnboardingStatusHero state, so the restore flow is missing the
in-progress pulse animation. Update DeviceRestoreView so the restoring state
explicitly passes pulse: true to OnboardingStatusHero, and if .idle should
remain static, split the shared helper or state-specific builders so only the
restoring path enables pulsing.
In `@ios/Cove/Flows/SendFlow/SendFlowConfirmScreen.swift`:
- Around line 11-16: The swipe control height is still hardcoded via
sendConfirmationActionReservedHeight, which prevents Dynamic Type from expanding
the action area and can clip larger text. Update SendFlowConfirmScreen and the
SwipeToSendView sizing logic so the action height is derived from its content
and padding instead of a fixed 70pt reservation; use the existing
sendConfirmationActionTopPadding and sendConfirmationActionBottomPadding
constants when calculating the final height.
In `@ios/Cove/Flows/TapSignerFlow/TapSignerImportRetryView.swift`:
- Around line 106-122: The background pattern and scroll-threshold logic are
duplicated across multiple TapSigner views, so move the shared `backgroundView`
behavior into a reusable `TapSignerResultBackground` component and extract
`usesScrollableLayout(availableHeight:)` into a common layout helper. Update
`TapSignerImportRetryView` and the matching duplicated views to use the shared
symbols instead of local copies, and centralize the breakpoint/pattern image
there so future changes only happen in one place.
In `@justfile`:
- Around line 158-166: The android stay-awake doc block contains a duplicated
summary line, so clean up the comment in justfile by removing the repeated “Run
an Android device command from android/ with stay-awake enabled.” text and
keeping a single clear description near the android-stay-awake recipe. Use the
surrounding comment block for the recipe and the references to
AndroidDeviceStayAwakeRule to preserve the intended guidance without the
copy/paste leftover.
---
Nitpick comments:
In
`@android/app/src/androidTest/java/org/bitcoinppl/cove/flows/NewWalletFlow/hot_wallet/HotWalletCreateScreenTest.kt`:
- Around line 118-147: Extract the repeated viewport/screenshot argument parsing
from HotWalletCreateScreenTest’s screenshotMode(), auditViewportWidth(),
auditViewportHeight(), and saveViewportScreenshot() into a shared test helper so
it matches the pattern already used by AndroidCompactLayoutAuditTest. Create or
reuse a central utility such as test/LayoutScreenshot.kt or
test/LayoutViewport.kt, then update this test to call the shared helper methods
instead of duplicating the InstrumentationRegistry argument parsing and default
viewport values.
In
`@android/app/src/main/java/org/bitcoinppl/cove/flows/OnboardingFlow/OnboardingCloudRestorePromptViews.kt`:
- Around line 371-372: The hero inner-circle size is hardcoded twice, causing
duplicated magic values between OnboardingCloudSearchHero and
OnboardingStatusHero. Hoist the shared 68.dp value into a single reusable
constant in OnboardingTheme.kt (for example alongside OnboardingStatusHero’s
existing innerBadgeSize) and update OnboardingCloudRestorePromptViews.kt to
reference that constant so both composables stay in sync.
In
`@ios/Cove/Flows/NewWalletFlow/HotWallet/VerifyWords/VerificationCompleteScreen.swift`:
- Line 12: Replace the deprecated sizeCategory environment usage in
VerificationCompleteScreen with dynamicTypeSize. Update the environment property
on the view to use `@Environment`(\.dynamicTypeSize), and adjust any size checks
in the same screen to compare against .xxLarge instead of the old
UIContentSizeCategory-based value.
In `@ios/Cove/Flows/NewWalletFlow/NewWalletSelectScreen.swift`:
- Around line 38-53: The GeometryReader-based scroll vs fixed-layout decision is
duplicated in NewWalletSelectScreen’s main layout and across the related select
screens, so extract it into a shared reusable container or ViewModifier (for
example, a generic ScrollableOrFixedLayout) that owns the available-height check
and the ScrollView vs bottomActionLayout branching. Update the existing uses of
usesScrollableLayout, mainContent, and bottomActionLayout to route through that
shared helper so the threshold logic and sizing behavior live in one place and
stay consistent.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: ade3c718-0e2e-4317-8a5e-a71d8d796405
📒 Files selected for processing (41)
android/app/src/androidTest/java/org/bitcoinppl/cove/flows/AndroidCompactLayoutAuditTest.ktandroid/app/src/androidTest/java/org/bitcoinppl/cove/flows/NewWalletFlow/hot_wallet/HotWalletCreateScreenTest.ktandroid/app/src/androidTest/java/org/bitcoinppl/cove/test/AndroidDeviceStayAwakeRule.ktandroid/app/src/androidTest/java/org/bitcoinppl/cove/test/FullLaunchTestRule.ktandroid/app/src/androidTest/java/org/bitcoinppl/cove/test/LayoutRegressionTest.ktandroid/app/src/androidTest/java/org/bitcoinppl/cove/test/LayoutScreenshot.ktandroid/app/src/main/java/org/bitcoinppl/cove/flows/NewWalletFlow/NewWalletSelectScreen.ktandroid/app/src/main/java/org/bitcoinppl/cove/flows/NewWalletFlow/hot_wallet/HotWalletCreateScreen.ktandroid/app/src/main/java/org/bitcoinppl/cove/flows/NewWalletFlow/hot_wallet/HotWalletImportScreen.ktandroid/app/src/main/java/org/bitcoinppl/cove/flows/NewWalletFlow/hot_wallet/HotWalletSelectScreen.ktandroid/app/src/main/java/org/bitcoinppl/cove/flows/NewWalletFlow/hot_wallet/VerificationCompleteScreen.ktandroid/app/src/main/java/org/bitcoinppl/cove/flows/NewWalletFlow/hot_wallet/VerifyWordsScreen.ktandroid/app/src/main/java/org/bitcoinppl/cove/flows/OnboardingFlow/OnboardingCloudRestorePromptViews.ktandroid/app/src/main/java/org/bitcoinppl/cove/flows/OnboardingFlow/OnboardingTheme.ktandroid/app/src/main/java/org/bitcoinppl/cove/flows/SendFlow/SendFlowConfirmScreen.ktandroid/app/src/main/java/org/bitcoinppl/cove/flows/TapSignerFlow/TapSignerAdvancedChainCode.ktandroid/app/src/main/java/org/bitcoinppl/cove/flows/TapSignerFlow/TapSignerChooseChainCode.ktandroid/app/src/main/java/org/bitcoinppl/cove/views/NumberPadPinView.ktandroid/app/src/screenshotTest/java/org/bitcoinppl/cove/screenshots/PreviewScreenshotTests.ktios/Cove.xcodeproj/project.pbxprojios/Cove/Flows/CoinControlFlow/UtxoListScreen.swiftios/Cove/Flows/NewWalletFlow/HotWallet/HotWalletCreateScreen.swiftios/Cove/Flows/NewWalletFlow/HotWallet/HotWalletSelectScreen.swiftios/Cove/Flows/NewWalletFlow/HotWallet/VerifyWords/VerificationCompleteScreen.swiftios/Cove/Flows/NewWalletFlow/HotWallet/VerifyWords/VerifyWordsScreen.swiftios/Cove/Flows/NewWalletFlow/NewWalletSelectScreen.swiftios/Cove/Flows/Onboarding/OnboardingBackupViews.swiftios/Cove/Flows/Onboarding/StartupRecovery/DeviceRestoreView.swiftios/Cove/Flows/SelectedWalletFlow/SecretWordsScreen.swiftios/Cove/Flows/SendFlow/SendFlowConfirmScreen.swiftios/Cove/Flows/TapSignerFlow/TapSignerAdvancedChainCode.swiftios/Cove/Flows/TapSignerFlow/TapSignerChooseChainCode.swiftios/Cove/Flows/TapSignerFlow/TapSignerImportRetryView.swiftios/Cove/Flows/TapSignerFlow/TapSignerImportSuccessView.swiftios/Cove/Flows/TapSignerFlow/TapSignerSetupRetryView.swiftios/Cove/Flows/TapSignerFlow/TapSignerSetupSuccessView.swiftios/Cove/Views/OnboardingRecoveryTheme.swiftios/CoveTests/HotWalletCreateScreenLayoutTests.swiftjustfilerust/xtask/src/android.rsrust/xtask/src/main.rs
praveenperera
force-pushed
the
cutoff-layout-issues
branch
from
22f9bb0 to
2b8f1e6
Compare
Make the recovery words screen scroll on compact Android and iOS heights so the primary action can fully enter the viewport. Add focused layout regression tests and move Android stay-awake test wrapping into xtask so device testing restores the previous setting.
Increase the inner badge size for shared onboarding status heroes so cloud icons no longer touch the rings. Add isolated previews and an Android preview screenshot entry to make the component easier to verify.
Refactor compact-screen wallet and signing flows Move key CTAs into fixed bottom-safe areas so primary actions remain visible. Add screenshot assertions that catch clipped or hidden actions in compact layouts.
Increase both Android wake-related settings during UI test runs Set alongside and restore both values after each run so long-running tests are less likely to be interrupted by idle sleep. Add iOS regression coverage for large recovery-word layouts by asserting word cards stay inside the horizontal viewport while still validating screenshot and CTA placement.
Reserve compact-screen space for bottom actions and add stable test tags so wallet and send confirmation screens remain accessible with small viewports.
Add viewport-aware compact audit checks and reusable screenshot capture for Android and iOS layout flows, and keep test devices awake during long-running screenshot runs.
Unify compact layout detection across iOS wallet and send flows.\nMove shared threshold logic into Constants for reuse.\nMake swipe-to-send height responsive to rendered content, so long\nlocalized labels remain fully visible.
Preserve and restore all Android device wake settings used by tests. Keep the previous power mode in place after each test run so subsequent commands inherit the preexisting configuration.
Split top and bottom sections into separate vertical groups in the send confirmation screen so controls stay anchored while amount and summary content can remain stable across layout changes.
praveenperera
force-pushed
the
cutoff-layout-issues
branch
from
2b8f1e6 to
0317613
Compare
Adjust Detekt to allow mixed-case function names and ignore unused private Compose preview helpers, matching existing Android UI code patterns. In the iOS hot wallet layout tests, rename the bottom-edge assertion to target the blue primary action and extract the repeated light-word-card pixel detection into shared helpers for clearer, reusable screenshot checks.
There was a problem hiding this comment.
🧹 Nitpick comments (1)
ios/Cove/Constants.swift (1)
21-22: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winDeduplicate the
812magic number.
isMiniDeviceandcompactLayoutHeightThresholdboth hardcode812independently. HaveisMiniDevicereference the new constant so the boundary has a single source of truth.♻️ Proposed fix
-let isMiniDevice = screenHeight <= 812 -let compactLayoutHeightThreshold: CGFloat = 812 +let compactLayoutHeightThreshold: CGFloat = 812 +let isMiniDevice = screenHeight <= compactLayoutHeightThreshold🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ios/Cove/Constants.swift` around lines 21 - 22, The 812 threshold is duplicated in the device layout constants, so update Constants.swift so isMiniDevice uses compactLayoutHeightThreshold instead of hardcoding the value itself. Keep compactLayoutHeightThreshold as the single source of truth and have the isMiniDevice calculation reference that symbol directly so any future boundary change only happens in one place.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@ios/Cove/Constants.swift`:
- Around line 21-22: The 812 threshold is duplicated in the device layout
constants, so update Constants.swift so isMiniDevice uses
compactLayoutHeightThreshold instead of hardcoding the value itself. Keep
compactLayoutHeightThreshold as the single source of truth and have the
isMiniDevice calculation reference that symbol directly so any future boundary
change only happens in one place.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 08a569c4-9c9f-41ac-b5a9-6f9e87b80457
📒 Files selected for processing (43)
android/app/src/androidTest/java/org/bitcoinppl/cove/flows/AndroidCompactLayoutAuditTest.ktandroid/app/src/androidTest/java/org/bitcoinppl/cove/flows/NewWalletFlow/hot_wallet/HotWalletCreateScreenTest.ktandroid/app/src/androidTest/java/org/bitcoinppl/cove/test/AndroidDeviceStayAwakeRule.ktandroid/app/src/androidTest/java/org/bitcoinppl/cove/test/FullLaunchTestRule.ktandroid/app/src/androidTest/java/org/bitcoinppl/cove/test/LayoutRegressionTest.ktandroid/app/src/androidTest/java/org/bitcoinppl/cove/test/LayoutScreenshot.ktandroid/app/src/main/java/org/bitcoinppl/cove/flows/NewWalletFlow/NewWalletSelectScreen.ktandroid/app/src/main/java/org/bitcoinppl/cove/flows/NewWalletFlow/hot_wallet/HotWalletCreateScreen.ktandroid/app/src/main/java/org/bitcoinppl/cove/flows/NewWalletFlow/hot_wallet/HotWalletImportScreen.ktandroid/app/src/main/java/org/bitcoinppl/cove/flows/NewWalletFlow/hot_wallet/HotWalletSelectScreen.ktandroid/app/src/main/java/org/bitcoinppl/cove/flows/NewWalletFlow/hot_wallet/VerificationCompleteScreen.ktandroid/app/src/main/java/org/bitcoinppl/cove/flows/NewWalletFlow/hot_wallet/VerifyWordsScreen.ktandroid/app/src/main/java/org/bitcoinppl/cove/flows/OnboardingFlow/OnboardingCloudRestorePromptViews.ktandroid/app/src/main/java/org/bitcoinppl/cove/flows/OnboardingFlow/OnboardingTheme.ktandroid/app/src/main/java/org/bitcoinppl/cove/flows/SendFlow/ConfirmScreen/SendFlowConfirmScreen.ktandroid/app/src/main/java/org/bitcoinppl/cove/flows/TapSignerFlow/TapSignerAdvancedChainCode.ktandroid/app/src/main/java/org/bitcoinppl/cove/flows/TapSignerFlow/TapSignerChooseChainCode.ktandroid/app/src/main/java/org/bitcoinppl/cove/views/NumberPadPinView.ktandroid/app/src/screenshotTest/java/org/bitcoinppl/cove/screenshots/PreviewScreenshotTests.ktandroid/detekt.ymlios/Cove.xcodeproj/project.pbxprojios/Cove/Constants.swiftios/Cove/Flows/CoinControlFlow/UtxoListScreen.swiftios/Cove/Flows/NewWalletFlow/HotWallet/HotWalletCreateScreen.swiftios/Cove/Flows/NewWalletFlow/HotWallet/HotWalletSelectScreen.swiftios/Cove/Flows/NewWalletFlow/HotWallet/VerifyWords/VerificationCompleteScreen.swiftios/Cove/Flows/NewWalletFlow/HotWallet/VerifyWords/VerifyWordsScreen.swiftios/Cove/Flows/NewWalletFlow/NewWalletSelectScreen.swiftios/Cove/Flows/Onboarding/OnboardingBackupViews.swiftios/Cove/Flows/Onboarding/StartupRecovery/DeviceRestoreView.swiftios/Cove/Flows/SelectedWalletFlow/SecretWordsScreen.swiftios/Cove/Flows/SendFlow/ConfirmScreen/SwipeToSendView.swiftios/Cove/Flows/SendFlow/SendFlowConfirmScreen.swiftios/Cove/Flows/TapSignerFlow/TapSignerAdvancedChainCode.swiftios/Cove/Flows/TapSignerFlow/TapSignerChooseChainCode.swiftios/Cove/Flows/TapSignerFlow/TapSignerContainer.swiftios/Cove/Flows/TapSignerFlow/TapSignerImportRetryView.swiftios/Cove/Flows/TapSignerFlow/TapSignerImportSuccessView.swiftios/Cove/Flows/TapSignerFlow/TapSignerSetupRetryView.swiftios/Cove/Flows/TapSignerFlow/TapSignerSetupSuccessView.swiftios/Cove/Views/OnboardingRecoveryTheme.swiftios/CoveTests/HotWalletCreateScreenLayoutTests.swiftjustfile
💤 Files with no reviewable changes (21)
- ios/Cove/Flows/TapSignerFlow/TapSignerContainer.swift
- ios/Cove/Flows/Onboarding/StartupRecovery/DeviceRestoreView.swift
- ios/Cove/Flows/CoinControlFlow/UtxoListScreen.swift
- ios/Cove/Views/OnboardingRecoveryTheme.swift
- justfile
- ios/Cove/Flows/SendFlow/SendFlowConfirmScreen.swift
- ios/Cove/Flows/TapSignerFlow/TapSignerImportSuccessView.swift
- ios/Cove/Flows/SendFlow/ConfirmScreen/SwipeToSendView.swift
- ios/Cove/Flows/TapSignerFlow/TapSignerSetupRetryView.swift
- ios/Cove/Flows/NewWalletFlow/NewWalletSelectScreen.swift
- ios/Cove/Flows/Onboarding/OnboardingBackupViews.swift
- ios/Cove/Flows/TapSignerFlow/TapSignerSetupSuccessView.swift
- ios/Cove/Flows/TapSignerFlow/TapSignerImportRetryView.swift
- ios/Cove/Flows/SelectedWalletFlow/SecretWordsScreen.swift
- ios/Cove/Flows/NewWalletFlow/HotWallet/VerifyWords/VerifyWordsScreen.swift
- ios/Cove/Flows/NewWalletFlow/HotWallet/VerifyWords/VerificationCompleteScreen.swift
- ios/Cove/Flows/TapSignerFlow/TapSignerAdvancedChainCode.swift
- ios/Cove/Flows/TapSignerFlow/TapSignerChooseChainCode.swift
- ios/Cove/Flows/NewWalletFlow/HotWallet/HotWalletCreateScreen.swift
- ios/Cove/Flows/NewWalletFlow/HotWallet/HotWalletSelectScreen.swift
- ios/CoveTests/HotWalletCreateScreenLayoutTests.swift
✅ Files skipped from review due to trivial changes (6)
- android/app/src/androidTest/java/org/bitcoinppl/cove/test/LayoutRegressionTest.kt
- android/app/src/main/java/org/bitcoinppl/cove/flows/NewWalletFlow/hot_wallet/HotWalletImportScreen.kt
- android/app/src/main/java/org/bitcoinppl/cove/flows/TapSignerFlow/TapSignerAdvancedChainCode.kt
- android/app/src/main/java/org/bitcoinppl/cove/flows/NewWalletFlow/hot_wallet/HotWalletSelectScreen.kt
- android/app/src/main/java/org/bitcoinppl/cove/flows/NewWalletFlow/NewWalletSelectScreen.kt
- android/app/src/main/java/org/bitcoinppl/cove/views/NumberPadPinView.kt
🚧 Files skipped from review as they are similar to previous changes (13)
- android/app/src/androidTest/java/org/bitcoinppl/cove/flows/NewWalletFlow/hot_wallet/HotWalletCreateScreenTest.kt
- android/app/src/main/java/org/bitcoinppl/cove/flows/TapSignerFlow/TapSignerChooseChainCode.kt
- android/app/src/androidTest/java/org/bitcoinppl/cove/test/LayoutScreenshot.kt
- android/app/src/screenshotTest/java/org/bitcoinppl/cove/screenshots/PreviewScreenshotTests.kt
- android/app/src/main/java/org/bitcoinppl/cove/flows/OnboardingFlow/OnboardingTheme.kt
- ios/Cove.xcodeproj/project.pbxproj
- android/app/src/main/java/org/bitcoinppl/cove/flows/OnboardingFlow/OnboardingCloudRestorePromptViews.kt
- android/app/src/main/java/org/bitcoinppl/cove/flows/NewWalletFlow/hot_wallet/VerifyWordsScreen.kt
- android/app/src/androidTest/java/org/bitcoinppl/cove/test/FullLaunchTestRule.kt
- android/app/src/main/java/org/bitcoinppl/cove/flows/NewWalletFlow/hot_wallet/HotWalletCreateScreen.kt
- android/app/src/androidTest/java/org/bitcoinppl/cove/test/AndroidDeviceStayAwakeRule.kt
- android/app/src/androidTest/java/org/bitcoinppl/cove/flows/AndroidCompactLayoutAuditTest.kt
- android/app/src/main/java/org/bitcoinppl/cove/flows/NewWalletFlow/hot_wallet/VerificationCompleteScreen.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix compact-screen layout cutoff issues across Android and iOS send, wallet setup, recovery-word, TapSigner, and onboarding restore flows.
Address review feedback by restoring Android
svc power stayonstate after stay-awake test helpers run, removing an invalid weighted spacer from a scrollable Compose column, centralizing iOS compact-layout threshold logic, sharing the TapSigner background view, restoring the active iCloud restore pulse animation, and allowing the iOS swipe-to-send control to grow with Dynamic Type.Testing
just fmtjust clippyjust compile-iosjust compile-androidjust lint-swiftjust lint-androidManual Device Coverage
Use one small and one large form factor per platform. On each screen, verify primary actions are visible or reachable, bottom actions are not clipped by safe areas/navigation bars, scrolling still works where needed, and horizontal content stays within the viewport.
iOS
Screens to cover:
Android
Screens to cover:
Checklist
Summary by CodeRabbit
New Features
Bug Fixes