Activate step executable #334
Conversation
|
|
||
| "github.com/bitrise-io/go-utils/command" | ||
| "github.com/bitrise-io/go-utils/pathutil" | ||
| "github.com/bitrise-io/stepman/models" | ||
| "github.com/bitrise-io/stepman/stepman" | ||
| ) | ||
|
|
||
| var errStepNotAvailableOfflineMode error = fmt.Errorf("step not available in offline mode") |
There was a problem hiding this comment.
Inlined this error handling into activateStepSource() because offline mode needs to be reworked for step executables anyway (we only cache the step source now, we'll need to cache the executables themselves)
| } | ||
|
|
||
| if destinationStepYML != "" { | ||
| if err := copyStepYML(stepLibURI, id, version, destinationStepYML); err != nil { |
There was a problem hiding this comment.
Moved this into both activateStepSource() and activateStepExecutable()
| @@ -75,46 +69,6 @@ func queryStep(stepLib models.StepCollectionModel, stepLibURI string, id, versio | |||
| return step, version, nil | |||
| } | |||
|
|
|||
| func activateStep(stepLib models.StepCollectionModel, stepLibURI, id, version string, step models.StepModel, log stepman.Logger, isOfflineMode bool) (string, error) { | |||
There was a problem hiding this comment.
➡️ activate_source.go
| @@ -138,8 +92,14 @@ func copyStepYML(libraryURL, id, version, dest string) error { | |||
| func ListCachedStepVersions(log stepman.Logger, stepLib models.StepCollectionModel, stepLibURI, stepID string) []string { | |||
| versions := []models.Semver{} | |||
|
|
|||
| for version, step := range stepLib.Steps[stepID].Versions { | |||
| _, err := activateStep(stepLib, stepLibURI, stepID, version, step, log, true) | |||
There was a problem hiding this comment.
This was doing a full step activation just to check the error. I replaced this with a proper stepman call
There was a problem hiding this comment.
Technically it is not a full update, as there is an offline flag set in the last parameter.
There was a problem hiding this comment.
Oh, true. The reason I had to replace this is the circular dependency between the activateStep() function that now calls this function.
ofalvai
force-pushed
the
ofalvai/activate-step-executable
branch
from
210db1e to
3b3418a
Compare
bitrise-io/bitrise#998
Initial support for storing pre-built binary URLs in published
step.ymls and activating the prebuilt binary for execution.Example step.yml snippet:
Out of scope for this PR: