Skip to content

Commit

Permalink
CI: Allow tests to run even if linting fails (#635)
Browse files Browse the repository at this point in the history
Handy for quickly running some experiments on the CI infrastructure.

The (required) `all` job does still depend on the `lint` job,
so PRs can't be merged with lint failures.
  • Loading branch information
leonschoorl authored Sep 4, 2024
1 parent 47ddc5e commit bc87829
Showing 1 changed file with 6 additions and 7 deletions.
13 changes: 6 additions & 7 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -146,10 +146,9 @@ jobs:
shell: git-nix-shell {0} --option connect-timeout 360 --pure --keep "GITHUB_SHA" --keep "S3_PASSWORD"
needs: [
build,
lint,
bittide-instances-hardware-in-the-loop,
bittide-instances-hardware-in-the-loop-test-matrix,
]
]

container:
image: ghcr.io/clash-lang/nixos-bittide-hardware:2024-08-07
Expand Down Expand Up @@ -207,7 +206,7 @@ jobs:
defaults:
run:
shell: git-nix-shell {0} --option connect-timeout 360 --pure --keep "GITHUB_SHA" --keep "S3_PASSWORD"
needs: [build, lint]
needs: [build]

container:
image: ghcr.io/clash-lang/nixos-bittide-hardware:2024-08-07
Expand Down Expand Up @@ -238,7 +237,7 @@ jobs:
defaults:
run:
shell: git-nix-shell {0} --option connect-timeout 360 --pure --keep "GITHUB_SHA" --keep "S3_PASSWORD"
needs: [build, lint]
needs: [build]

container:
image: ghcr.io/clash-lang/nixos-bittide-hardware:2024-08-07
Expand Down Expand Up @@ -391,7 +390,7 @@ jobs:
defaults:
run:
shell: git-nix-shell {0} --option connect-timeout 360 --pure --keep "GITHUB_SHA" --keep "S3_PASSWORD"
needs: [build, lint]
needs: [build]

container:
image: ghcr.io/clash-lang/nixos-bittide-hardware:2024-08-07
Expand All @@ -418,7 +417,7 @@ jobs:
defaults:
run:
shell: git-nix-shell {0} --option connect-timeout 360 --pure --keep "GITHUB_SHA" --keep "S3_PASSWORD"
needs: [build, lint]
needs: [build]

container:
image: ghcr.io/clash-lang/nixos-bittide-hardware:2024-08-07
Expand Down Expand Up @@ -520,7 +519,7 @@ jobs:
run:
# We leave out '--pure', as 'with_vivado.sh' relies on basic Ubuntu
shell: git-nix-shell {0} --option connect-timeout 360
needs: [build, lint, bittide-instances-hdl-matrix]
needs: [build, bittide-instances-hdl-matrix]

strategy:
matrix:
Expand Down

0 comments on commit bc87829

Please sign in to comment.