Turn on TreatWarningsAsError

[justindbaur]

🎟️ Tracking

📔 Objective

Add <TreatWarningsAsErrors>true</TreatWarningsAsErrors> which means it should be a bad idea to merge to main with new warnings. I have temporarily excluded issues that exist today. It does technically allow new warnings of those types to get introduced but all new warnings types will block.

NOTE: This only blocks warnings for Configuration=Release builds, not during normal development when you would run with Configuration=Debug this can be nice as it allows you to experiment and test your changes easier but it can also suck when the build works locally but fails in CI. Luckily it it pretty easy to recreate the CI behavior with dotnet build -c Release.

📸 Screenshots

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.30%. Comparing base (7e47e13) to head (3f83277).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5384   +/-   ##
=======================================
  Coverage   44.30%   44.30%           
=======================================
  Files        1497     1497           
  Lines       69207    69207           
  Branches     6241     6241           
=======================================
  Hits        30661    30661           
  Misses      37223    37223           
  Partials     1323     1323           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

Checkmarx One – Scan Summary & Details – ac080e7b-265c-4422-8da0-9b1003bb6825

Great job, no security vulnerabilities found in this Pull Request

[Patrick-Pimentel-Bitwarden]

👍 Looks good to me.