Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lib.rs #46

Merged
merged 1 commit into from
Jun 2, 2016
Merged

Update lib.rs #46

merged 1 commit into from
Jun 2, 2016

Conversation

0xpr03
Copy link
Contributor

@0xpr03 0xpr03 commented May 31, 2016

Fixes Cargo.toml example from generating warning: dependency (regex) specified without providing a local path, Git repository, or version to use. warnings, which will be failures in the future.

@0xpr03
Copy link
Contributor Author

0xpr03 commented May 31, 2016

(While using * for dependencies isn't allowed for libraries, in that case it would generate an error also.)

@blackbeam
Copy link
Owner

Thanks. Could you please add relevant comment to issue #36 before i merge?

@0xpr03
Copy link
Contributor Author

0xpr03 commented Jun 1, 2016

You mean #46 aren't you ?

… dependency (regex) specified without providing a local path, Git repository, or version to use.` error
@0xpr03
Copy link
Contributor Author

0xpr03 commented Jun 1, 2016

I think this should do it, while I don't know why the builds are failing at dep. fetching..

@blackbeam
Copy link
Owner

You mean #46 aren't you ?

No). I meant post this text as a comment to #36:

I license past and future contributions under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option

I hope to close it one day..

@0xpr03
Copy link
Contributor Author

0xpr03 commented Jun 1, 2016

Oh, sorry, seems like I oversaw that part, thought it's something only you have to sign..

@blackbeam blackbeam merged commit 3a8de64 into blackbeam:master Jun 2, 2016
@0xpr03 0xpr03 deleted the patch-1 branch June 2, 2016 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants