Add support for UUIDs #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement FromValue for the Uuid type.
|
Thanks. I will look into it. Could you please leave that message in #36 :
|
| fn new(v: Value) -> MyResult<UuidIr> { | ||
| match v { | ||
| Value::Bytes(bytes) => match Uuid::from_bytes(bytes.as_slice()) { | ||
| Ok(val) => Ok(UuidIr { val: val }), |
There was a problem hiding this comment.
Please move bytes into UuidIr here to not to reallocate on rollback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements the FromValue trait for the Uuid type.
It is quite convenient to do that because it reduces the boilerplate when writing SQL queries.
It's an optional feature so, no new dependencies are introduced by default.
I understand that UUIDs are not an official SQL type, but since traits can only be implemented in either the crate the trait or the struct was defined in, this feature has to be implemented in either the uuid or the mysql crate. And doing that in the uuid crate would obviously be wrong.