Skip to content

Conversation

@ALTracer
Copy link
Contributor

@ALTracer ALTracer commented Sep 7, 2025

Detailed description

  • No new features.
  • The existing problem is LPC546xx: Part ID 0x4294264328 being logged as highlighted by recent advancements in LPC546xx flash loading broken #1520. Should be 0xfff54608.
  • The PR solves it by swapping format specifier in lpc546xx.c to lowercase hexadecimal, like in lpc11xx.c and others.

This existed since #1522 which was my 7th merged PR here, I was not as experienced or acquainted with codebase, also untested on unavailable LPC silicon. By grepping current drivers I don't see other obvious instances of this.
grep 'DEBUG_INFO.*ID.*PRIu32' src/target/*.c one unrelated hit in adiv5.c
grep 'DEBUG_INFO.*ID.*PRIx32' src/target/*.c 14 hits.

Your checklist for this pull request

Closing issues

@dragonmux dragonmux added this to the v2.1 release milestone Sep 7, 2025
@dragonmux dragonmux added the Bug Confirmed bug label Sep 7, 2025
Copy link
Member

@dragonmux dragonmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merging. Thank you for the contribution!

@dragonmux dragonmux merged commit 76e13f2 into blackmagic-debug:main Sep 7, 2025
38 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Confirmed bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants