Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit test for turkish stemmer #2128

Merged
merged 3 commits into from
Jan 6, 2025
Merged

Unit test for turkish stemmer #2128

merged 3 commits into from
Jan 6, 2025

Conversation

umuttalha
Copy link
Contributor

What this PR does:

  • Adds a test file for the Snowball Turkish stemmer.
  • Tests various Turkish words to ensure proper stemming.

Why this is useful:

  • Improves test coverage for Turkish language support in Bleve.
  • Ensures the Snowball stemmer works as expected for Turkish words.

Notes:

  • This PR only adds a test file and does not modify any existing functionality.

abhinavdangeti
abhinavdangeti reviewed Jan 6, 2025
View reviewed changes
Copy link
Member

@abhinavdangeti abhinavdangeti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this commit @umuttalha in improving our code test coverage. A minor comment for you.

analysis/lang/tr/stemmer_tr_test.go Outdated
@@ -0,0 +1,115 @@
// Copyright (c) 2020 Couchbase, Inc.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2025*

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed the date. thanks

@abhinavdangeti abhinavdangeti added this to the v2.5.0 milestone Jan 6, 2025
@abhinavdangeti abhinavdangeti changed the title Turkish stemmer test Unit test for turkish stemmer Jan 6, 2025
@abhinavdangeti abhinavdangeti merged commit 2c696d8 into blevesearch:master Jan 6, 2025
9 checks passed
@umuttalha umuttalha deleted the turkish-stemmer-test branch January 6, 2025 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhinavdangeti abhinavdangeti abhinavdangeti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@umuttalha @abhinavdangeti