MB-64883 - Avoid redundant computation of eligible IDs #2143
+25
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metonymic-smokey
requested review from
abhinavdangeti,
Thejas-bhat,
CascadingRadium and
Likith101
abhinavdangeti
previously approved these changes
Feb 20, 2025
|
@metonymic-smokey with the type for |
abhinavdangeti
approved these changes
Feb 21, 2025
|
@abhinavdangeti yes, that's why I changed it. The throughput still isn't too great but as far as I know, no queries are failing unlike when the tests were first run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, filter eligible hits, which aren't specific to a segment, are computed redundantly for each segment.
This PR pre-computes the eligible segment IDs and re-uses these for each segment.