Skip to content

Add JSON labels to Genesis structs #926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wolf31o2 opened this issue Mar 3, 2025 · 2 comments · Fixed by #960 or #964
Closed

Add JSON labels to Genesis structs #926

wolf31o2 opened this issue Mar 3, 2025 · 2 comments · Fixed by #960 or #964
Assignees
@arepala-uml
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@wolf31o2
Copy link
Member

wolf31o2 commented Mar 3, 2025

Some of the structs are missing them, which causes the golangci-lint musttag linter to fail. I think it's a good idea to be explicit on there. Fix the issue and remove the //nolint:musttag comments to test.
@wolf31o2 wolf31o2 added enhancement New feature or request good first issue Good for newcomers labels Mar 3, 2025
@wolf31o2 wolf31o2 mentioned this issue Mar 3, 2025
Merged
@krishnaindani
Copy link

Hi, could I contribute to this?

@wolf31o2
Copy link
Member Author

wolf31o2 commented Mar 4, 2025

Sure. 😃

@arepala-uml arepala-uml self-assigned this Mar 21, 2025
@arepala-uml arepala-uml mentioned this issue Mar 23, 2025
Merged
@arepala-uml arepala-uml reopened this Mar 24, 2025
@arepala-uml arepala-uml mentioned this issue Mar 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arepala-uml arepala-uml

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
3 participants
@wolf31o2 @krishnaindani @arepala-uml