Skip to content

Add JSON labels to Genesis structs #960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 23, 2025
Merged

Add JSON labels to Genesis structs #960

merged 3 commits into from
Mar 23, 2025

Conversation

arepala-uml
Copy link
Contributor

  1. Added missing json struct tags to multiple genesis structs.
  2. Remove nolint comments from reader constructors
  3. Add unit tests to verify JSON decoding

Closes #926

@arepala-uml arepala-uml marked this pull request as ready for review March 23, 2025 19:17
@arepala-uml arepala-uml requested a review from a team as a code owner March 23, 2025 19:17
wolf31o2
wolf31o2 approved these changes Mar 23, 2025
View reviewed changes
Copy link
Member

@wolf31o2 wolf31o2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM... when you squash and merge, update the commit message to something like:

fix(ledger): json labels on genesis objects

@arepala-uml arepala-uml merged commit d21cc8b into main Mar 23, 2025
9 checks passed
@arepala-uml arepala-uml deleted the genesis_structs branch March 23, 2025 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolf31o2 wolf31o2 wolf31o2 approved these changes

@agaffney agaffney Awaiting requested review from agaffney

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add JSON labels to Genesis structs
2 participants
@arepala-uml @wolf31o2