-
Notifications
You must be signed in to change notification settings - Fork 32
fix(leiosfetch): answer unconfigured requests instead of holding agency #2173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
7175355
fix(leiosfetch): answer unconfigured requests instead of holding agency
wolf31o2 d2a3f0f
fix(leiosfetch): serialize block request admission
wolf31o2 5730ee2
chore: merge origin/main into fix/3623-leiosfetch-slot
wolf31o2 e147ef6
fix(leiosfetch): admit votes and range requests through the slot
wolf31o2 2463098
fix(leiosfetch): release the slot when a votes or range caller gives up
wolf31o2 3654866
fix(leiosfetch): correlate votes and range responses
wolf31o2 83e7b7e
fix(leiosfetch): quarantine abandoned range requests
wolf31o2 b136417
fix(leiosfetch): use one response slot for all requests
wolf31o2 d9c67d4
fix(leiosfetch): retain range delivery through terminal response
wolf31o2 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This documents behaviour the code does not currently have:
deliverfrees the slot on the first range message, not the terminal one (see the inline comment onhandleNextBlockAndTxsInRange).Worth re-checking this paragraph once the streaming fix lands — as written it is the right specification, so it may need no edit at all beyond confirming the code matches it.