Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add @web3-onboard/okx #2229

Merged
merged 4 commits into from
Jun 13, 2024
Merged

Conversation

vanishcode
Copy link
Contributor

Description

okx sdk module support

PLEASE NOTE- Checklist must be complete prior to review.

Checklist

  • Increment the version field in package.json of the package you have made changes in following semantic versioning and using alpha release tagging
  • Check the box that allows repo maintainers to update this PR
  • Test locally to make sure this feature/fix works
  • Run yarn check-all to confirm there are not any associated errors
  • Confirm this PR passes Circle CI checks
  • Add or update relevant information in the documentation

Docs Checklist

  • Include a screenshot of any changes (see docs README on running locally)
  • Add/update the appropriate package README (if applicable)
  • Add/update the related module in the docs demo (if applicable)
  • Add/update the related package in the docs/package.json file (if applicable)

If this PR includes changes to add an injected wallet or SDK wallet module:

Please complete the following using the internal demo package.
To run this demo use the command yarn && yarn dev to get the project running at http://localhost:8080/

Tests with demo app (injected)

  • send transaction
  • switch chains
  • sign message
  • sign typed message
  • disconnect

Tests with demo app (SDK)

  • send transaction
  • switch chains
  • sign message
  • sign typed message
  • disconnect

Copy link

socket-security bot commented Jun 13, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@0xpass/[email protected] None 0 11.1 kB kwk236
npm/@0xpass/[email protected] network 0 20.7 kB kwk236
npm/@0xpass/[email protected] None 0 92.3 kB kwk236
npm/@0xpass/[email protected] None +1 310 kB kwk236
npm/@adraffy/[email protected] None 0 446 kB adraffy
npm/@ampproject/[email protected] None 0 76 kB jridgewell
npm/@apocentre/[email protected] None 0 24.3 kB antwnic4
npm/@arcana/[email protected] network 0 928 kB makyl
npm/@babel/[email protected] None +2 31.6 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 50.5 kB nicolo-ribaudo
npm/@babel/[email protected] environment, filesystem, unsafe +10 2.26 MB nicolo-ribaudo
npm/@babel/[email protected] None 0 4.02 kB nicolo-ribaudo
npm/@babel/[email protected] None +1 116 kB nicolo-ribaudo
npm/@babel/[email protected] None +5 303 kB nicolo-ribaudo
npm/@babel/[email protected] unsafe +1 267 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 54.4 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 4.41 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 11.6 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 1.89 MB nicolo-ribaudo
npm/@babel/[email protected] None +1 16 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 6.86 kB nicolo-ribaudo
npm/@babel/[email protected] None +3 225 kB nicolo-ribaudo
npm/@babel/[email protected] unsafe 0 14 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 130 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 21.5 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 262 kB nicolo-ribaudo
npm/@babel/[email protected] None +3 1.11 MB nicolo-ribaudo
npm/@babel/[email protected] environment +1 2.44 MB nicolo-ribaudo
npm/@blocto/[email protected] None 0 20.1 kB scottphc
npm/@cedelabs/[email protected] Transitive: environment +1 9.96 MB cedelabs
npm/@celo/[email protected] None 0 210 kB alecps
npm/@celo/[email protected] None +9 1.84 MB alecps
npm/@chainsafe/[email protected] None 0 165 kB dapplion
npm/@chainsafe/[email protected] None 0 112 kB dapplion
npm/@chainsafe/[email protected] None 0 468 kB dapplion
npm/@coinbase/[email protected] network +2 1.28 MB jungho.bang
npm/@cspotcode/[email protected] filesystem 0 133 kB cspotcode
npm/@cspotcode/[email protected] filesystem 0 43.5 kB cspotcode
npm/@discoveryjs/[email protected] None 0 83.3 kB lahmatiy
npm/@emotion/[email protected] environment Transitive: filesystem +4 226 kB emotion-release-bot
npm/@emotion/[email protected] environment +4 189 kB emotion-release-bot
npm/@emotion/[email protected] environment +1 33.4 kB emotion-release-bot
npm/@emotion/[email protected] environment +6 688 kB emotion-release-bot
npm/@emotion/[email protected] environment +3 91.4 kB emotion-release-bot
npm/@emotion/[email protected] environment +5 246 kB emotion-release-bot
npm/@emotion/[email protected] environment 0 7.05 kB emotion-release-bot
npm/@esbuild/[email protected] None 0 11.1 MB evanw
npm/@esbuild/[email protected] None 0 9.57 MB evanw
npm/@esbuild/[email protected] None 0 11.1 MB evanw
npm/@esbuild/[email protected] None 0 9.51 MB evanw
npm/@esbuild/[email protected] None 0 9.92 MB evanw
npm/@esbuild/[email protected] None 0 8.65 MB evanw
npm/@esbuild/[email protected] None 0 9.35 MB evanw
npm/@esbuild/[email protected] None 0 8.85 MB evanw
npm/@esbuild/[email protected] None 0 8.65 MB evanw
npm/@esbuild/[email protected] None 0 8.9 MB evanw
npm/@esbuild/[email protected] None 0 9.11 MB evanw
npm/@esbuild/[email protected] None 0 10.2 MB evanw
npm/@esbuild/[email protected] None 0 8.91 MB evanw
npm/@esbuild/[email protected] None 0 8.85 MB evanw
npm/@esbuild/[email protected] None 0 9.77 MB evanw
npm/@esbuild/[email protected] None 0 9.35 MB evanw
npm/@esbuild/[email protected] None 0 9.33 MB evanw
npm/@esbuild/[email protected] None 0 9.37 MB evanw
npm/@esbuild/[email protected] None 0 9.33 MB evanw
npm/@esbuild/[email protected] None 0 8.76 MB evanw
npm/@esbuild/[email protected] None 0 9.2 MB evanw
npm/@esbuild/[email protected] None 0 9.55 MB evanw
npm/@eslint/[email protected] filesystem, unsafe +1 204 kB eslintbot
npm/@ethereumjs/[email protected] None +2 2.9 MB holgerd77
npm/@ethereumjs/[email protected] None 0 384 kB holgerd77
npm/@ethereumjs/[email protected] None +8 3.3 MB holgerd77
npm/@ethersproject/[email protected] None 0 498 kB ricmoo
npm/@formatjs/[email protected] None +1 313 kB longlho
npm/@formatjs/[email protected] None +1 214 kB longlho
npm/@gsap/[email protected] None 0 18.7 kB greensock
npm/@humanwhocodes/[email protected] None +1 84.3 kB nzakas
npm/@ioredis/[email protected] None 0 55.6 kB ioredis-robot
npm/@jridgewell/[email protected] None +1 94.7 kB jridgewell
npm/@jridgewell/[email protected] None 0 55.2 kB jridgewell
npm/@jridgewell/[email protected] None 0 164 kB jridgewell
npm/@keepkey/[email protected] None 0 1.89 MB mcchadwick
npm/@lit-labs/[email protected] None 0 32.5 kB lit-robot
npm/@lit/[email protected] None 0 785 kB lit-robot
npm/@magic-sdk/[email protected] None 0 12.1 kB smithki
npm/@magic-sdk/[email protected] environment Transitive: network +13 2.09 MB magiclabs_fe
npm/@magic-sdk/[email protected] None 0 140 kB magiclabs_fe
npm/@metamask/[email protected] network +5 271 kB metamaskbot
npm/@metamask/[email protected] Transitive: environment +3 149 kB gudahtt
npm/@metamask/[email protected] Transitive: environment +3 178 kB gudahtt
npm/@metamask/[email protected] environment, filesystem +2 12.5 MB metamaskbot
npm/@metamask/[email protected] environment 0 8.27 MB metamaskbot
npm/@metamask/[email protected] Transitive: environment, network +10 29.2 MB metamaskbot
npm/@motionone/[email protected] None +3 95.1 kB popmotion
npm/@motionone/[email protected] None +3 568 kB popmotion
npm/@motionone/[email protected] None 0 263 kB popmotion
npm/@motionone/[email protected] None 0 819 kB popmotion
npm/@myetherwallet/[email protected] Transitive: environment, eval, filesystem, network, shell +46 18.2 MB kvhnuke
npm/@ngraveio/[email protected] None 0 114 kB antwnic4
npm/@niceties/[email protected] None 0 40.7 kB kshutkin
npm/@noble/[email protected] None 0 84 kB paulmillr
npm/@noble/[email protected] None 0 106 kB paulmillr
npm/@nothing-but/[email protected] None 0 104 kB thetarnav.
npm/@parcel/[email protected] None 0 406 kB devongovett
npm/@parcel/[email protected] None 0 328 kB devongovett
npm/@parcel/[email protected] None 0 327 kB devongovett
npm/@parcel/[email protected] None 0 551 kB devongovett
npm/@parcel/[email protected] None 0 436 kB devongovett
npm/@parcel/[email protected] None 0 455 kB devongovett
npm/@parcel/[email protected] None 0 463 kB devongovett
npm/@parcel/[email protected] None 0 546 kB devongovett
npm/@parcel/[email protected] None 0 509 kB devongovett
npm/@parcel/[email protected] filesystem 0 218 kB devongovett
npm/@parcel/[email protected] None 0 533 kB devongovett
npm/@parcel/[email protected] None 0 431 kB devongovett
npm/@parcel/[email protected] None 0 533 kB devongovett
npm/@parcel/[email protected] None +1 412 kB devongovett
npm/@ramp-network/[email protected] None 0 350 kB jakubsta
npm/@rollup-extras/[email protected] filesystem Transitive: environment, unsafe +3 6.74 MB kshutkin
npm/@rollup/[email protected] None 0 15.7 kB shellscape
npm/@rollup/[email protected] filesystem +1 95 kB shellscape
npm/@rollup/[email protected] environment, filesystem +2 310 kB shellscape
npm/@safe-global/[email protected] None 0 33.5 kB dasanra
npm/@shapeshiftoss/[email protected] None +1 234 kB shapeshift-ci-bot
npm/@shapeshiftoss/[email protected] None 0 21.5 kB shapeshift-ci-bot
npm/@shapeshiftoss/[email protected] None 0 329 kB shapeshift-ci-bot
npm/@sideway/[email protected] None 0 56.4 kB hueniverse
npm/@solid-devtools/[email protected] None +13 550 kB thetarnav.
npm/@solid-primitives/[email protected] None 0 49.8 kB thetarnav.
npm/@solid-primitives/[email protected] None 0 28.4 kB thetarnav.
npm/@solid-primitives/[email protected] None 0 54 kB thetarnav.
npm/@stencil/[email protected] None 0 52 MB ionicjs
npm/@tanstack/[email protected] environment 0 1.86 MB tannerlinsley
npm/@tanstack/[email protected] environment 0 1.95 MB tannerlinsley
npm/@toruslabs/[email protected] network +7 8.66 MB chaitanyapotti
npm/@toruslabs/[email protected] network 0 239 kB chaitanyapotti
npm/@trezor/[email protected] network Transitive: environment +2 68.3 kB trezor-ci
npm/@trezor/[email protected] None 0 51.9 kB trezor-ci
npm/@trezor/[email protected] None +1 77 kB trezor-ci
npm/@trezor/[email protected] None +4 1.79 MB trezor-ci
npm/@trezor/[email protected] environment 0 4.95 kB trezor-ci
npm/@trezor/[email protected] Transitive: environment +1 168 kB trezor-ci
npm/@trezor/[email protected] Transitive: environment, filesystem, network, unsafe +10 13.3 MB trezor-ci
npm/@tsconfig/[email protected] None 0 2.31 kB typescript-deploys
npm/@tsconfig/[email protected] None 0 2.4 kB typescript-deploys
npm/@tsconfig/[email protected] None 0 2.29 kB typescript-deploys
npm/@tsconfig/[email protected] None 0 2.29 kB typescript-deploys
npm/@tsconfig/[email protected] None 0 3.11 kB typescript-deploys
npm/@types/[email protected] None 0 8.3 kB types
npm/@types/[email protected] None 0 5.81 kB types
npm/@types/[email protected] None 0 5.41 kB types
npm/@types/[email protected] None 0 6.14 kB types
npm/@types/[email protected] None 0 60.4 kB types
npm/@types/[email protected] None +1 169 kB types
npm/@types/[email protected] None +2 93.3 kB types
npm/@types/[email protected] None +3 31.3 kB types
npm/@types/[email protected] None +1 14.8 kB types
npm/@types/[email protected] None 0 12.8 kB types
npm/@types/[email protected] None 0 5.76 kB types
npm/@types/[email protected] None 0 32.2 kB types
npm/@types/[email protected] None 0 3.3 kB types
npm/@types/[email protected] None 0 3.34 kB types
npm/@types/[email protected] None 0 3.31 kB types
npm/@types/[email protected] None 0 863 kB types
npm/@types/[email protected] None 0 3.65 MB types
npm/@types/[email protected] None 0 6.55 kB types
npm/@types/[email protected] None 0 9.86 kB types
npm/@types/[email protected] None +1 183 kB types
npm/@types/[email protected] None 0 7.87 kB types
npm/@types/[email protected] None 0 13.1 kB types
npm/@types/[email protected] None 0 8.05 kB types
npm/@types/[email protected] None 0 5.19 kB types
npm/@types/[email protected] None 0 5.84 kB types
npm/@types/[email protected] None 0 7.25 kB types
npm/@types/[email protected] None 0 8.97 kB types
npm/@types/[email protected] None 0 3.61 kB types
npm/@typescript-eslint/[email protected] Transitive: environment, filesystem +9 4.55 MB jameshenry
npm/@typescript-eslint/[email protected] Transitive: environment, filesystem +4 1.32 MB jameshenry
npm/@uauth/[email protected] network 0 298 kB braden-pezeshki
npm/@unstoppabledomains/[email protected] None 0 446 kB unstoppable_sam
npm/@usecapsule/[email protected] None 0 13.7 MB vtig2020
npm/@usecapsule/[email protected] network Transitive: eval +8 746 kB tbosch
npm/@usecapsule/[email protected] None 0 73.6 kB vtig2020
npm/@usecapsule/[email protected] Transitive: environment, eval, network +12 2.83 MB tbosch
npm/@usecapsule/[email protected] None 0 10.7 kB tbosch
npm/@usecapsule/[email protected] None 0 35.2 kB tbosch
npm/@venly/[email protected] network +1 1.26 MB venly_io
npm/@vue/[email protected] environment, eval +2 1.59 MB yyx990803
npm/@vue/[email protected] environment, eval +1 824 kB yyx990803
npm/@vue/[email protected] environment, eval, filesystem, unsafe +3 2.21 MB yyx990803
npm/@vue/[email protected] environment +1 333 kB yyx990803
npm/@vue/[email protected] environment +1 1.03 MB yyx990803
npm/@vue/[email protected] environment +2 3.26 MB yyx990803
npm/@vue/[email protected] environment, eval +3 2.77 MB yyx990803
npm/@vueuse/[email protected] network +2 1.1 MB antfu
npm/@vueuse/[email protected] None +1 191 kB antfu
npm/@wagmi/[email protected] None 0 240 kB jmoxey
npm/@wagmi/[email protected] Transitive: environment +11 37 MB awkweb
npm/@wagmi/[email protected] Transitive: environment +1 2.08 MB awkweb
npm/@walletconnect/[email protected] environment, network +2 2.84 MB gancho_walletconnect
npm/@walletconnect/[email protected] None 0 3.48 MB gancho_walletconnect
npm/[email protected] environment Transitive: network +15 2.89 MB pkieltyka
npm/[email protected] Transitive: environment, filesystem +7 639 kB evilebottnawi
npm/[email protected] None 0 83.5 kB evilebottnawi
npm/[email protected] environment, filesystem, unsafe Transitive: shell +11 376 kB evilebottnawi
npm/[email protected] environment, eval, network Transitive: filesystem, shell, unsafe +21 2.69 MB evilebottnawi

🚮 Removed packages: npm/@algolia/[email protected], npm/@antfu/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@cosmjs/[email protected], npm/@cosmjs/[email protected], npm/@cosmjs/[email protected], npm/@cosmjs/[email protected], npm/@cosmjs/[email protected], npm/@cosmjs/[email protected], npm/@cosmjs/[email protected], npm/@cosmjs/[email protected], npm/@docsearch/[email protected], npm/@docsearch/[email protected], npm/@ethereumjs/[email protected], npm/@ethereumjs/[email protected], npm/@ethersproject/[email protected], npm/@ethersproject/[email protected], npm/@ethersproject/[email protected], npm/@ethersproject/[email protected], npm/@ethersproject/[email protected], npm/@iconify-json/[email protected], npm/@iconify/[email protected], npm/@lit-labs/[email protected], npm/@lit/[email protected], npm/@motionone/[email protected], npm/@motionone/[email protected], npm/@motionone/[email protected], npm/@motionone/[email protected], npm/@ngraveio/[email protected], npm/@safe-global/[email protected], npm/@shapeshiftoss/[email protected], npm/@sveltejs/[email protected], npm/@sveltejs/[email protected], npm/@svelteness/[email protected], npm/@tailwindcss/[email protected], npm/@toruslabs/[email protected], npm/@toruslabs/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@vitejs/[email protected], npm/@walletconnect/[email protected], npm/@walletconnect/[email protected], npm/@walletconnect/[email protected], npm/@walletconnect/[email protected], npm/@walletconnect/[email protected], npm/@walletconnect/[email protected], npm/@web3-onboard/[email protected], npm/@web3-onboard/[email protected], npm/@web3-onboard/[email protected], npm/@web3-onboard/[email protected], npm/@web3-onboard/[email protected], npm/@web3-onboard/[email protected], npm/@web3-onboard/[email protected], npm/@web3-onboard/[email protected], npm/@web3-onboard/[email protected], npm/@web3-onboard/[email protected], npm/@web3-onboard/[email protected], npm/@web3-onboard/[email protected], npm/@web3-onboard/[email protected], npm/@web3-onboard/[email protected], npm/@web3-onboard/[email protected], npm/@web3-onboard/[email protected], npm/@web3-onboard/[email protected], npm/@web3-onboard/[email protected], npm/@web3-onboard/[email protected], npm/@web3-onboard/[email protected], npm/@web3-onboard/[email protected], npm/@web3-onboard/[email protected], npm/@web3-onboard/[email protected], npm/@web3-onboard/[email protected], npm/@web3-onboard/[email protected], npm/@web3-onboard/[email protected], npm/@web3-onboard/[email protected], npm/@web3-onboard/[email protected], npm/@web3-onboard/[email protected], npm/@web3-onboard/[email protected], npm/@web3-onboard/[email protected], npm/@web3-onboard/[email protected], npm/@web3auth/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

Copy link

socket-security bot commented Jun 13, 2024

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
Install scripts npm/[email protected]
  • Install script: install
  • Source: npm run rebuild || echo "Secp256k1 bindings compilation fail. Pure JS implementation will be used."
Install scripts npm/[email protected]
  • Install script: postinstall
  • Source: echo "WARNING: the web3-shh and web3-bzz api will be deprecated in the next version"
Install scripts npm/[email protected]
  • Install script: postinstall
  • Source: echo "WARNING: the web3-bzz api will be deprecated in the next version"
Install scripts npm/[email protected]
  • Install script: postinstall
  • Source: echo "WARNING: the web3-shh api will be deprecated in the next version"
Install scripts npm/[email protected]
  • Install script: install
  • Source: npm run rebuild || echo "Couldn't build bindings. Non-native version used."
Install scripts npm/[email protected]
  • Install script: install
  • Source: npm run rebuild || echo "Secp256k1 bindings compilation fail. Pure JS implementation will be used."
Install scripts npm/[email protected]
  • Install script: postinstall
  • Source: node scripts/postinstall
Install scripts npm/[email protected]
Install scripts npm/@sveltejs/[email protected]
  • Install script: postinstall
  • Source: node postinstall.js
Protestware/Troll package npm/[email protected]
  • Note: This package prints a protestware console message on install regarding Ukraine for users with Russian language locale
Install scripts npm/[email protected]
  • Install script: postinstall
  • Source: node -e "try{require('./_postinstall')}catch(e){}" || exit 0

View full report↗︎

Next steps

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

What is protestware?

This package is a joke, parody, or includes undocumented or hidden behavior unrelated to its primary function.

Consider that consuming this package my come along with functionality unrelated to its primary purpose.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

Copy link
Member

@Adamj1232 Adamj1232 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @vanishcode! Thank you again for the collaboration and the hard work!

@Adamj1232 Adamj1232 merged commit 5626431 into blocknative:develop Jun 13, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants