Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update the '@metamask/sdk' to version '0.20.5' #2231

Conversation

omridan159
Copy link
Contributor

@omridan159 omridan159 commented Jun 13, 2024

Description

Update the '@metamask/sdk' to version '0.20.5'

PLEASE NOTE- Checklist must be complete prior to review.

Checklist

  • Increment the version field in package.json of the package you have made changes in following semantic versioning and using alpha release tagging
  • Check the box that allows repo maintainers to update this PR
  • Test locally to make sure this feature/fix works
  • Run yarn check-all to confirm there are not any associated errors
  • Confirm this PR passes Circle CI checks
  • Add or update relevant information in the documentation

Docs Checklist

  • Include a screenshot of any changes (see docs README on running locally)
  • Add/update the appropriate package README (if applicable)
  • Add/update the related module in the docs demo (if applicable)
  • Add/update the related package in the docs/package.json file (if applicable)

If this PR includes changes to add an injected wallet or SDK wallet module:

Please complete the following using the internal demo package.
To run this demo use the command yarn && yarn dev to get the project running at http://localhost:8080/

Tests with demo app (injected)

  • send transaction
  • switch chains
  • sign message
  • sign typed message
  • disconnect

Tests with demo app (SDK)

  • send transaction
  • switch chains
  • sign message
  • sign typed message
  • disconnect

@@ -60,7 +60,7 @@
"typescript": "^5.2.2"
},
"dependencies": {
"@metamask/sdk": "^0.20.3",
"@metamask/sdk": "^0.20.5",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For a new package to publish the version above this on line 3 of this file needs a bump to 2.1.2-alpha.1 which will result in an alpha version published of @web3-onboard/metamask
We will also want to add this new version update to packages/demo/package.json and run yarn && yarn check-all from the root of the project and ensure there are not any errors

Copy link

socket-security bot commented Jun 13, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@esbuild-plugins/[email protected] Transitive: environment, filesystem, network, shell +24 227 MB xmorse
npm/@esbuild-plugins/[email protected] filesystem Transitive: environment, network, shell, unsafe +30 229 MB xmorse
npm/@ethersproject/[email protected] None 0 30.1 kB ricmoo
npm/@ethersproject/[email protected] None 0 46.8 kB ricmoo
npm/@ethersproject/[email protected] network 0 1.11 MB ricmoo
npm/@ethersproject/[email protected] network 0 127 kB ricmoo
npm/@fontsource/[email protected] None 0 1.02 MB lotusdevshack
npm/@jridgewell/[email protected] None 0 40 kB jridgewell
npm/@lit/[email protected] None +1 800 kB lit-robot
npm/@rollup/[email protected] filesystem +8 834 kB shellscape
npm/@stablelib/[email protected] None +3 157 kB dchest
npm/@sveltejs/[email protected] environment, filesystem, shell +1 78.4 kB svelte-admin
npm/@sveltejs/[email protected] environment, eval, filesystem Transitive: network, unsafe +16 2.69 MB svelte-admin
npm/@types/[email protected] None 0 9.76 kB types
npm/@types/[email protected] None 0 25.7 kB types
npm/@typescript-eslint/[email protected] Transitive: environment, filesystem +12 4.46 MB jameshenry
npm/@typescript-eslint/[email protected] Transitive: environment, filesystem +5 1.45 MB jameshenry
npm/@walletconnect/[email protected] None 0 103 kB gancho_walletconnect
npm/@walletconnect/[email protected] None +1 188 kB gancho_walletconnect
npm/@walletconnect/[email protected] None +1 345 kB gancho_walletconnect
npm/@walletconnect/[email protected] None 0 215 kB gancho_walletconnect
npm/@walletconnect/[email protected] None 0 218 kB bkrem
npm/@web3-onboard/[email protected] None +1 524 kB cmeisl
npm/@web3-onboard/[email protected] Transitive: environment, eval, filesystem, network, unsafe +138 31.1 MB cmeisl
npm/[email protected] None +3 193 kB ljharb
npm/[email protected] None +1 34.6 kB cwmma
npm/[email protected] None 0 3.68 kB cwmma
npm/[email protected] None +1 980 kB dignifiedquire
npm/[email protected] None +1 101 kB feross
npm/[email protected] None +5 100 kB ljharb
npm/[email protected] None 0 7.95 kB cwmma
npm/[email protected] None +1 12.9 kB cwmma
npm/[email protected] None 0 5.81 kB cwmma
npm/[email protected] None +10 305 kB cwmma
npm/[email protected] None 0 6.09 kB samverschueren
npm/[email protected] None 0 30.4 kB tehshrike
npm/[email protected] None +3 62.7 kB ljharb
npm/[email protected] None 0 18.2 kB lydell
npm/[email protected] None 0 41.3 kB conduitry
npm/[email protected] filesystem Transitive: unsafe +8 4.85 MB eslintbot
npm/[email protected] None +1 12.8 kB dcousens
npm/[email protected] filesystem 0 91.9 kB mrmlnc
npm/[email protected] eval +4 106 kB ljharb
npm/[email protected] None +1 22.7 kB ljharb
npm/[email protected] None 0 17.6 kB ljharb
npm/[email protected] None 0 6.03 kB dcousens
npm/[email protected] None 0 6.8 kB feross
npm/[email protected] None 0 4.41 kB hughsk
npm/[email protected] None 0 33.2 kB substack
npm/[email protected] None 0 9.22 kB jonschlinkert
npm/[email protected] Transitive: unsafe +1 71.4 kB ljharb
npm/[email protected] None 0 13.8 kB cwmma
npm/[email protected] environment 0 254 kB dummdidumm
npm/[email protected] environment, filesystem, unsafe 0 11.7 MB prettier-bot
npm/[email protected] None 0 6.36 kB cwmma
npm/[email protected] environment +5 147 kB matteo.collina
npm/[email protected] None 0 9.79 kB dcousens
npm/[email protected] None +3 1.52 MB fredkschott
npm/[email protected] environment, filesystem +1 2.68 MB lukastaegert
npm/[email protected] None 0 32.1 kB feross
npm/[email protected] None 0 31.1 kB dcousens
npm/[email protected] Transitive: environment +2 150 kB goto-bus-stop
npm/[email protected] None +3 49.6 kB sindresorhus
npm/[email protected] Transitive: environment, filesystem +8 4.75 MB svelte-language-tools-deploy
npm/[email protected] environment, filesystem Transitive: eval +16 2.85 MB dummdidumm
npm/[email protected] None 0 9.74 MB conduitry
npm/[email protected] None 0 60 kB typescript-bot
npm/[email protected] None +1 624 kB achingbrain

🚮 Removed packages: npm/@types/[email protected], npm/@types/[email protected], npm/@web3-onboard/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

Copy link

socket-security bot commented Jun 13, 2024

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
Install scripts npm/[email protected]
  • Install script: postinstall
  • Source: echo "[svelte-preprocess] Don't forget to install the preprocessors packages that will be used: sass, stylus, less, postcss & postcss-load-config, coffeescript, pug, etc..."
Install scripts npm/@sveltejs/[email protected]
  • Install script: postinstall
  • Source: node postinstall.js
Install scripts npm/[email protected]

View full report↗︎

Next steps

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@Adamj1232
Copy link
Member

Closing as this change has been implemented and available with the latest alpha version of @web3-onboard/metamask

@Adamj1232 Adamj1232 closed this Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants