Remove PS UI kit and fix css issues #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The first 2 commits belong the older PR #151 and they have already been reviewed. Feedback for 8fb596d here: #151 (comment) Feedback for 6338ac here: #151 (comment) |
anktd
changed the title
|
The PR looks good and the changes are working correctly. Let's revert the changes in order.css as this file should not change between integrations and has been designed to inherit the themes font, colors etc. |
DarrenWestwood
approved these changes
Aug 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continued from #151
We are currently using Prestashop UI Kit for our payment controller, which is causing JS console errors (as mentioned in #150) and some minor css issues on our checkout page, as can be seen below:
After updating the UIKit to it's latest version resolves JS Console errors but these css issues on checkout still remain.
Prestashop Devdocs tell us that UIKit is needed for some components are not provided from Bootstrap. We are not using these custom components in our module.
Fix
We remove the UIKit files from our module and check all changes caused in checkout due to this, and fix them also. There are other issues that are not directly related to removal of UIKit but are addressed in this PR only as they relate to checkout css only.
Other changes addressed after removing UIKit:
Fonts on the checkout page and select BTC /BCH page changes ✅05d8908 -> reverted in 7b8a3bf$this->bootstrap = true;in our module class, this we have already done here.