-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Php 8.2 Deprecation Warning Fixes #387
Merged
shivaenigma
merged 10 commits into
blockonomics:master
from
anktd:fix/php82-deprecated-null-submenu
Dec 4, 2024
Merged
Php 8.2 Deprecation Warning Fixes #387
shivaenigma
merged 10 commits into
blockonomics:master
from
anktd:fix/php82-deprecated-null-submenu
Dec 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested changes working with Php 8.2.0, 8.1.13 and 7.4.33 ✅ |
ashthecoder05
approved these changes
Dec 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Added some clarifying questions for my understanding 🎖️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently a bug was reported about deprecated warning on installing the Blockonomics plugin -> Ticket here.
Fix: Changed the parent slug in
add_submenu_page()
from empty string to'options.php'
to resolve PHP 8.1 deprecation warnings while maintaining hidden menu functionality ➞ f7784a3null
:strpos()
: When WordPress checks menu hierarchystr_replace()
: During menu slug processing''
) (as the suggested fix by user report):strip_tags()
'options.php'
:Other fixes in this PR:
Remove incorrect
wpdb::prepare
usage in uninstall hook by removing unnecessary prepare call for static queries ➞ 20fa454Added explicit property declaration
private $api_key;
to the Blockonomics_Setup class to comply with PHP 8.2's deprecation of dynamic properties ➞ 573320a