fix(launcher): database macros with custom_prefix

[rimrakhimov]

database! macros with custom_prefix did not work for test_database because TestDbGuard::new expected a test name to be &str but the resultant macro passed it as a String. This PR fixes that

Summary by CodeRabbit

• Chores
  • Updated blockscout-service-launcher package version from 0.16.1 to 0.16.2
• Refactor
  • Modified test database macro to pass database name as a reference

[coderabbitai]

Walkthrough

The pull request introduces two primary changes in the blockscout-service-launcher library. First, the package version in Cargo.toml is incremented from "0.16.1" to "0.16.2", a minor version update. Second, in the test_database.rs file, a modification is made to the database! macro, specifically changing how the TestDbGuard::new method is called when using a custom prefix. The change involves passing the database name as a reference instead of a direct value, which may impact how the string is handled within the method.

Possibly related PRs

• feat(launcher): db connect options #1182: Updates blockscout-service-launcher package version in Cargo.toml
• feat(multichain): update launcher #1190: Modifies blockscout-service-launcher dependency version

Poem

🐰 A Rabbit's Ode to Code Refinement 🔧

In Rust's domain, a version springs,
From 0.16.1 to 0.16.2 it sings!
A macro's dance, with reference bright,
Precision coded with rabbit's might.
Small changes bloom like springtime's art! 🌱

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d5125c0 and 636cb93.

📒 Files selected for processing (2)

• libs/blockscout-service-launcher/Cargo.toml (1 hunks)
• libs/blockscout-service-launcher/src/test_database.rs (1 hunks)

✅ Files skipped from review due to trivial changes (1)

• libs/blockscout-service-launcher/Cargo.toml

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Unit, doc and integration tests

🔇 Additional comments (2)

libs/blockscout-service-launcher/src/test_database.rs (2)

220-222: LGTM! The change improves efficiency by avoiding unnecessary ownership transfer.

The modification correctly passes a reference to the database name string, which is what TestDbGuard::new expects. This change:

1. Prevents unnecessary cloning of the string
2. Aligns with Rust's ownership model
3. Fixes the compilation issue with custom prefix

---

219-223: Consider adding test cases to verify the fix.

Since this change specifically addresses issues with custom prefixes in parameterized tests, it would be valuable to add test cases that verify:

1. The macro works correctly with rstest parameterized tests
2. Different custom prefixes generate unique database names
3. The fix handles edge cases (e.g., very long custom prefixes)

Let me help you verify the current test coverage:

Would you like me to help draft these test cases?

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.