Cli + Config #246
Closed
Cli + Config #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -16,7 +16,7 @@ solana-rpc-client-api = { workspace = true } | |||
| solana-transaction-status = { workspace = true } | |||
| solana-version = { workspace = true } | |||
| serde = { workspace = true } | |||
| serde_json = { workspace = true } | |||
| serde_json = "1.0.108" | |||
There was a problem hiding this comment.
why not change the version in workspace itself.
godmodegalactus
requested changes
Nov 23, 2023
| use quote::{quote, ToTokens}; | ||
| use syn::{Data, Expr}; | ||
|
|
||
| struct Arg<'a> { |
There was a problem hiding this comment.
Why do you have to do this, why cant you do the same as yellowstone-grpc justing using serde parse. It would be simpler to maintain rather than doing some custom stuff ?
https://github.com/rpcpool/yellowstone-grpc/blob/master/yellowstone-grpc-geyser/src/config.rs
There was a problem hiding this comment.
This does not even enable to create sections, that we had discussed about.
| ty: &'a syn::Type, | ||
| desc: Option<Expr>, | ||
| default: Option<Expr>, | ||
| short: Option<Expr>, |
There was a problem hiding this comment.
short is no longer required, the config file should be readable.
grooviegermanikus
requested changes
Nov 27, 2023
There was a problem hiding this comment.
@aniketfuryrocks could you provide+commit an example for local config.json please
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.