Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simple config, env and cli #247

Merged
merged 9 commits into from
Nov 27, 2023
Merged

simple config, env and cli #247

merged 9 commits into from
Nov 27, 2023

Conversation

aniketfuryrocks
Copy link
Contributor

No description provided.

Copy link
Collaborator

@godmodegalactus godmodegalactus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

lite-rpc/src/cli.rs Outdated Show resolved Hide resolved
@godmodegalactus
Copy link
Collaborator

squash all commits into one, and then we can approve.

| `DISABLE_GSO` | Disable GSO completely | no |
Thank you for providing the default values. Here's the updated table with the default values for the environment variables based on the additional information:

| Environment Variable | Purpose | Required? | Default Value |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should provide a config file example instead of environment variables.

@aniketfuryrocks aniketfuryrocks merged commit 3eecb89 into main Nov 27, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants