Refactor Tx sender wallet handling and clean up AbstractTx.

Changed the sender wallet handling to return null instead of throwing an exception in Tx.java to allow flexibility in error management. Also, removed redundant 'amounts' field and its initialization from AbstractTx.java for a cleaner codebase.
bloxbean · Nov 24, 2024 · 588d3ae · 588d3ae
1 parent 41c2615
commit 588d3ae
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/quicktx/src/main/java/com/bloxbean/cardano/client/quicktx/AbstractTx.java b/quicktx/src/main/java/com/bloxbean/cardano/client/quicktx/AbstractTx.java
@@ -38,7 +38,6 @@ public abstract class AbstractTx<T> {
     //custom change address
     protected String changeAddress;
     protected List<Utxo> inputUtxos;
-    protected List<Amount> amounts;
 
     //Required for script
     protected PlutusData changeData;
@@ -214,9 +213,7 @@ protected T payToAddress(String address, List<Amount> amounts, byte[] datumHash,
                 .address(address)
                 .value(Value.builder().coin(BigInteger.ZERO).build())
                 .build();
-        if(this.amounts == null)
-            this.amounts = new ArrayList<>();
-        this.amounts.addAll(amounts);
+
         for (Amount amount : amounts) {
             String unit = amount.getUnit();
             if (unit.equals(LOVELACE)) {

diff --git a/quicktx/src/main/java/com/bloxbean/cardano/client/quicktx/Tx.java b/quicktx/src/main/java/com/bloxbean/cardano/client/quicktx/Tx.java
@@ -522,7 +522,7 @@ protected Wallet getFromWallet() {
         if(senderWallet != null)
             return senderWallet;
         else
-            throw new TxBuildException("No sender wallet defined");
+            return null;
     }
 
     @Override