feat: support for CIP-30 payload hash with an extra overloaded methods #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matiwinnetou
force-pushed
the
cip-30-hash
branch
3 times, most recently
from
8ef07a8 to
a54da8c
Compare
matiwinnetou
changed the title
matiwinnetou
changed the title
matiwinnetou
force-pushed
the
cip-30-hash
branch
3 times, most recently
from
9e7f1f9 to
b839a19
Compare
matiwinnetou
force-pushed
the
cip-30-hash
branch
2 times, most recently
from
ebf53a3 to
5e7433a
Compare
matiwinnetou
force-pushed
the
cip-30-hash
branch
from
5e7433a to
117a275
Compare
Refactor `COSESignBuilder` and `COSESign1Builder` to handle external payloads and add support for payload hashing. Update `CIP30DataSigner` logic to remove redundant hashed payload header. Adjust tests to align with these changes and add new test files for Rust code comparisons.
matiwinnetou
force-pushed
the
cip-30-hash
branch
from
478d003 to
779d9fa
Compare
Refactor COSESign builders for external payload and hashing
matiwinnetou
force-pushed
the
cip-30-hash
branch
from
779d9fa to
43e4436
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.