-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust the fee calculation when reference script bytes are present in the input UTXOs of a transaction #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce getOrElse to return a default value if an exception occurs. Add orElseThrow to allow custom exceptions when computation fails.
Introduced the getRefScriptHashes method in TxBuilderContext. This method aggregates reference script hashes from UTXOs and internal reference scripts, returning them as a Set of Strings.
Reorganized serialization and deserialization methods across Script, PlutusScript, and NativeScript classes. Updated tests to verify the correct handling of multiple script types, including PlutusV1, PlutusV2, PlutusV3, and NativeScript.
Introduced a new method to check for multi-asset minting in transactions. Updated the transaction builder to account for multi-asset minting when removing duplicate script witnesses. Made adjustments in the `DuplicateScriptWitnessChecker` to handle native scripts.
nemo83
approved these changes
Oct 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
fabianbormann
approved these changes
Oct 11, 2024
Sotatek-HuyLe3a
approved these changes
Oct 15, 2024
Handle NativeScript as ScriptRef
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix #450
A script reference can be part of the regular inputs in a script transaction. For example, if the reference script is part of the spending UTXO, a reference input is not required.
Update the
FeeCalculator
to calculate the reference script size in inputs and adjust the fee accordingly.If both a script reference and a script witness (
transaction.getWitnessSet().getPlutusXScript()
) are present,ExtraneousScriptWitnessesUTXOW
is thrown. To fix this,DuplicateScriptWitnessChecker
is introduced, which returns a composable function to remove any duplicate witnesses.A new API
removeDuplicateScriptWitnesses(boolean flag)
has been added toQuickTxBuilder
to enable the removal of duplicate witnesses in the above scenario. By default, this flag is false, but it can be enabled by calling the above method if required.Tx
api.