#466 Convert JSON object to CBORMetadataMap and JSON Array to CBORMetadataList / New methods in MetadataBuilder #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ods public and handle null value
satran004
changed the title
Added several new unit tests for MetadataBuilder and improved the handling of byte strings in the metadata converter. Also included multiple new test JSON files to cover different metadata scenarios.
satran004
changed the title
|
Sotatek-HuyLe3a
approved these changes
Nov 19, 2024
edridudi
pushed a commit
to adabox-aio/cardano-client-lib
that referenced
this pull request
Feb 27, 2025
… CBORMetadataList / New methods in MetadataBuilder (bloxbean#467) * bloxbean#466 Make json object --> CBOR Map and json array --> CBOR Array methods public and handle null value * bloxbean#466 fixed tests * bloxbean#466 Handle BigInteger encoded as ByteString * Add unit tests and improve metadata JSON handling Added several new unit tests for MetadataBuilder and improved the handling of byte strings in the metadata converter. Also included multiple new test JSON files to cover different metadata scenarios. * To fix Sonarcloud warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current State:
Currently, we have low-level classes such as
CBORMetadata,CBORMetadataMap, etc., and a few helper classes likeMetadataToJsonNoSchemaConverterandJsonNoSchemaToMetadataConverterfor creating metadata or converting metadata to JSON. This sometimes creates confusion regarding how to work with metadata.Although we have a relatively new builder class,
MetadataBuilder, with static helper methods for creating metadata without using low-levelCBORMetadataAPIs, it lacks the necessary conversion methods directly from or to JSON.Summary of Changes:
This PR introduces new helper methods to
MetadataBuilderto simplify the process of metadata creation and conversion. In most cases, the use of existing low-level APIs will no longer be necessary.New Methods in
MetadataBuilderMetadata Creation Methods:
createMetadata()– Creates an instance ofMetadata.createMap()– Creates an instance ofMetadataMap.createList()– Creates an instance ofMetadataList.Deserialization:
deserialize(byte[] cborBytes)– Deserializes CBOR byte arrays into aMetadataobject.JSON to Metadata Conversion Methods:
metadataFromJson(String json)– Converts a JSON string to aMetadataobject.metadataFromJsonBody(BigInteger label, String jsonBody)– Converts a JSON string into aMetadataobject with a specified label, handling both JSON objects and arrays.metadataMapFromJsonBody(String jsonBody)– Parses a JSON body string to create aMetadataMapinstance.metadataListFromJsonBody(String jsonBody)– Parses a JSON body string to create aMetadataListinstance.Metadata to JSON Conversion Methods:
toJson(Metadata metadata)– Converts aMetadataobject to its JSON string representation.toJson(byte[] serializedCbor)– Converts a CBOR byte array to a JSON string.