Skip to content
This repository was archived by the owner on Dec 1, 2021. It is now read-only.

Replace EasyDict to SmartDict #1220

Merged
merged 4 commits into from
Sep 28, 2020
Merged

Replace EasyDict to SmartDict #1220

merged 4 commits into from
Sep 28, 2020

Conversation

iizukak
Copy link
Member

@iizukak iizukak commented Sep 28, 2020

Solve #1092

Odoku-san implemnetd EasyDict. We can replace EasyDict to SmartDict.

@iizukak iizukak requested a review from oatawa1 September 28, 2020 02:27
@blueoil-butler blueoil-butler bot added the CI: auto-run Run CI automatically label Sep 28, 2020
@bo-code-review-bot
Copy link

This PR needs Approvals as follows.

  • Readability Approval for Python from tkng, tsawada, tfujiwar, a-hanamoto

Please choose reviewers and requet reviews!

Click to see how to approve each reviews

You can approve this PR by triggered comments as follows.

  • Approve all reviews requested to you (readability and ownership) and LGTM review
    Approval, LGTM

  • Approve all ownership reviews
    Ownership Approval or OA

  • Approve all readability reviews
    Readability Approval or RA

  • Approve specified review targets

    • Example of Ownership Reviewer of /: Ownership Approval for / or OA for /
    • Example of Readability Reviewer of Python: Readability Approval for Python or RA for Python

  • Approve LGTM review
    LGTM

See all trigger comments

Please replace [Target] to review target

  • Ownership Approval
    • Ownership Approval for [Target]
    • OA for [Target]
    • Ownership Approval
    • OA
    • Approval
  • Readability Approval
    • Readability Approval for [Target]
    • RA for [Target]
    • [Target] Readability Approval
    • [Target] RA
    • Readability Approval
    • RA
    • Approval
  • LGTM
    • LGTM
    • lgtm

oatawa1
oatawa1 reviewed Sep 28, 2020
View reviewed changes
Copy link
Contributor

@oatawa1 oatawa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I leave one comment.

@iizukak iizukak requested a review from oatawa1 September 28, 2020 04:03
oatawa1
oatawa1 approved these changes Sep 28, 2020
View reviewed changes
Copy link
Contributor

@oatawa1 oatawa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Such a big PR. Thank you.

@iizukak iizukak requested a review from tfujiwar September 28, 2020 04:21
tfujiwar
tfujiwar approved these changes Sep 28, 2020
View reviewed changes
Copy link
Contributor

@tfujiwar tfujiwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RA

@iizukak
Copy link
Member Author

iizukak commented Sep 28, 2020

/ready

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Sep 28, 2020

⏳Merge job is queued...

@bo-mergebot bo-mergebot bot merged commit 8387f17 into blue-oil:master Sep 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@oatawa1 oatawa1 oatawa1 approved these changes

@tfujiwar tfujiwar tfujiwar approved these changes

Assignees
No one assigned
Labels
CI: auto-run Run CI automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iizukak @oatawa1 @tfujiwar