-
Notifications
You must be signed in to change notification settings - Fork 8
feat: Notestation #154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: Notestation #154
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR integrates Notestation development tooling and modernizes the development container configuration. It adds a VS Code extension for Notestation, updates the development environment to use Docker Compose with Tailscale networking, and makes various configuration improvements.
Changes:
- Added Notestation VS Code extension (notestation-2.0.0.vsix) and VS Code task configuration for building Arduino examples
- Migrated devcontainer from simple Docker image to Docker Compose setup with Tailscale integration for remote hardware access
- Updated development tooling including Arduino CLI version bump (1.1.1 → 1.4.0) and lcov configuration modernization
Reviewed changes
Copilot reviewed 8 out of 11 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
.vscode/tasks.json |
Added new task for building Arduino examples with board selection |
.vscode/launch.json |
Removed trailing comma for JSON formatting compliance |
.vscode/extensions/notestation-2.0.0.vsix |
Added VS Code extension binary for Notestation integration |
.gitignore |
Added patterns for Python wheels, zip files, and environment files |
test/run_all_tests.sh |
Updated lcov parameters from legacy format to modern syntax |
Pipfile and Pipfile.lock |
Added Python environment configuration files |
.devcontainer/docker-compose.yaml |
New Docker Compose configuration with Tailscale service |
.devcontainer/devcontainer.json |
Migrated to Docker Compose with enhanced VS Code extensions and Tailscale setup |
.devcontainer/Dockerfile |
Changed base image to notestation-client and updated Arduino CLI version |
.devcontainer/.env.example |
Added example file for Tailscale authentication configuration |
Comments suppressed due to low confidence (1)
.devcontainer/Dockerfile:19
- The Dockerfile now depends on a custom base image (ghcr.io/blues/notestation-client:latest) instead of debian:bookworm-slim. There's a commented-out alternative that references a local image. This creates a dependency on an external image that may not be publicly available or documented. Consider adding documentation about this base image, what it contains, and how it can be built if needed. The commented line 19 suggests there might be a way to build it locally, but this isn't explained.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| env_file: | ||
| - .env | ||
| - ts_config.env # Load Tailscale config from generated file |
Copilot
AI
Jan 13, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docker-compose.yaml file references two environment files (.env and ts_config.env) but only .env.example is provided in the PR. The ts_config.env file is generated by the initializeCommand in devcontainer.json, but this dependency and setup process is not clearly documented. Consider adding documentation about how to set up the required .env file (copying from .env.example and adding the Tailscale auth key) and explaining that ts_config.env will be auto-generated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be an implementation detail, and I'm not sure why it would need to be described to the user.
Bucknalla
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only the one comment about the dev container image
| name: note-arduino | ||
| services: | ||
| devcontainer: | ||
| # image: ghcr.io/blues/note_arduino_ci:latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this comment still? It requires being built locally?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left that in, so I could test local base images when I need to update the notestation CLI (and thus the Dockerfile).
d457267 to
832c006
Compare
19265a8 to
6f8ba8d
Compare
Docker image with Notestation base is too large for GitHub CI
No description provided.