Open
Conversation
Switch avatar, banner, feed_thumbnail, and feed_fullsize presets to default to WebP for better compression. Existing URLs with @jpeg in the path continue to work since the format is parsed from the URL and overrides the preset default. - Add WebP branch to sharp image processor - Include format in cache keys to prevent collisions between formats - Invalidate all format variants (jpeg, png, webp) on cache clear - Accept webp as a valid format in URI path validation - Update tests to reflect new default format Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Fix prettier formatting in uri.test.ts - Update server.test.ts to expect image/webp instead of image/jpeg Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I won't pretend to be an expert at this part of the codebase, but the tests pass!
Summary
Backward compatibility
Old URLs with
@jpegin the path continue to work — the format is parsed from the URL and overrides the preset default. The cache key now includes format, so old and new URLs are stored/served independently.Note: If
OZONE_CDN_PATHStemplates are format-specific (e.g. contain@jpeg), the deployment config should be updated to include@webpvariants so CDN invalidation covers new URLs.Test plan
packages/bsky/tests/image/uri.test.ts— all 6 tests pass🤖 Generated with Claude Code