goat: update to v3 of urfav/cli #926
Open
+203
−237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianolson
approved these changes
Feb 3, 2025
|
cli v3 is still "beta1", maybe wait for full 3.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transition guide here: https://cli.urfave.org/migrate-v2-to-v3/
Overall updates are good/fine, but the big win and motivation here is finally having CLI arg parsing order be more flexible.
Eg:
# --did is a boolean flag goat resolve --did atproto.com goat resolve atproto.com --didIn v2, only the first is allowed, while with v3 the later works.
I'll probably do this update/refactor across all our commands soon.