Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openbmc, supermicro: implement BMCResetter interface #380

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

joelrebel
Copy link
Member

What does this PR implement/change/remove?

This makes sure when the provider is pinned/filtered* the BmcReset method is available.

Checklist

  • Tests added
  • Similar commits squashed

The HW vendor this change applies to (if applicable)

OpenBMC firmware, Supermicros

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (4d960aa) 43.40% compared to head (91cfd91) 43.37%.

Files Patch % Lines
providers/supermicro/supermicro.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #380      +/-   ##
==========================================
- Coverage   43.40%   43.37%   -0.04%     
==========================================
  Files          59       59              
  Lines        5140     5144       +4     
==========================================
  Hits         2231     2231              
- Misses       2692     2696       +4     
  Partials      217      217              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This makes sure when the provider is pinned/filtered* the BmcReset method is
available.

* https://github.com/bmc-toolbox/bmclib#one-time-filtering
@joelrebel joelrebel force-pushed the openbmc-smc-bmcreset branch from 9467b1f to 91cfd91 Compare December 6, 2023 13:00
@joelrebel
Copy link
Member Author

rebased on main

@joelrebel joelrebel merged commit 1063371 into main Dec 6, 2023
5 of 7 checks passed
@joelrebel joelrebel deleted the openbmc-smc-bmcreset branch December 6, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants