-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FS-1123: Supermicro (SMC) BIOS config Get, Set and Reset support via SUM #392
Merged
Merged
Changes from 12 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
57bec53
FS-1123: Supermicro (SMC) BIOS config Get, Set and Reset support via SUM
splaspood 62dd780
FS-1123: Update devcontainer Dockerfile to use go 1.22
splaspood 61c6387
FS-1123: Import latest bmc-toolbox/common
splaspood 45b9aef
FS-1123: Enhancements to examples/bios
splaspood d49516d
FS-1123: Supermicro Update Manager (SUM) provider
splaspood 57710dc
FS-1123: Pin to bmc-toolbox/common@cfd9f1a6c4ad3253e074a34bca4e2aa7f2…
splaspood 200eec6
go.mod: Update bmc-toolbox/common version
splaspood 9c572ad
internal/sum: Convert providers/sum into an internal package
splaspood 246e002
internal/sum/sum.go: Use explict returns
splaspood 678cddf
go.sum: go mod tidy
splaspood 2cfd480
Implement sum test cases and a mocked Executor model
splaspood 5da5153
internal/sum/sum.go: s/Mvcli/Sum/g
splaspood 1796b4f
internal/sum/sum.go: Remove unused NewFakeSum func
splaspood fe3202b
internal/sum/sum.go: Provide a link and description re supermicro upd…
splaspood 9e1f090
internal/sum/sum_test.go: Fix test for Sum.Run(); Upgrade bmc-toolbox…
splaspood 00ac9db
fixtures/internal/sum/GetBIOSInfo: Add mock data for GetBIOSInfo command
splaspood File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
FROM mcr.microsoft.com/devcontainers/go:1-1.21-bullseye | ||
FROM mcr.microsoft.com/devcontainers/go:1-1.22-bullseye | ||
RUN apt update | ||
RUN apt install ipmitool -y | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
Supermicro Update Manager (for UEFI BIOS) 2.14.0 (2024/02/15) (ARM64) | ||
Copyright(C) 2013-2024 Super Micro Computer, Inc. All rights reserved. | ||
.................[0m | ||
[0m | ||
|
||
[1m[1m[1mNote:[0m[0m [0mNo BIOS setting has been changed. | ||
|
||
[0m[1m[1m[1mStatus:[0m[0m [0mThe BIOS configuration is updated for 10.145.129.168 | ||
|
||
[0m[1m[1m[1mNote:[0m[0m [0mYou have to reboot or power up the system for the changes to take effect. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
Supermicro Update Manager (for UEFI BIOS) 2.14.0 (2024/02/15) (ARM64) | ||
Copyright(C) 2013-2024 Super Micro Computer, Inc. All rights reserved. | ||
..................[0m | ||
[0m[1m[1m[1mStatus:[0m[0m [0mThe BIOS configuration is updated for 10.145.129.168 | ||
|
||
[0m[1m[1m[1mNote:[0m[0m [0mYou have to reboot or power up the system for the changes to take effect. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
Supermicro Update Manager (for UEFI BIOS) 2.14.0 (2024/02/15) (ARM64) | ||
Copyright(C) 2013-2024 Super Micro Computer, Inc. All rights reserved. | ||
.................[0m | ||
[0m[1m[1m[1mStatus:[0m[0m [0mThe managed system 10.145.129.168 is rebooting. | ||
|
||
.............................[0mDone | ||
.... | ||
.................[0m | ||
[0m | ||
|
||
[1m[1m[1mNote:[0m[0m [0mNo BIOS setting has been changed. | ||
|
||
[0m[1m[1m[1mStatus:[0m[0m [0mThe BIOS configuration is updated for 10.145.129.168 | ||
|
||
[0m[0m[0;33m[0;33m[0;33mWARNING[0m[0m: [0mWithout option --post_complete, please manually confirm the managed system is POST complete before executing next action. | ||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are we using a Microsoft golang container?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd guess simply because that's what's suggested in the devcontainer documentation/examples. My understanding is there's nothing really special about the devcontainer image(s) so we could replace that with anything.