Improve virtual media ejecting and inserting: #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As there can be multiple virtual media for a single manager, i.e. CD, DVD, USBStick, etc, we need to check for a matching supported type before ejecting or injecting. Also, added checking that the virtual media supports injecting before trying. Signed-off-by: Jacob Weinstock <[email protected]>
jacobweinstock
force-pushed
the
more-virtual-media-stuff
branch
from
c3247de to
b58a061
Compare
joelrebel
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR implement/change/remove?
As there can be multiple virtual media for a single manager, i.e. CD, DVD, USBStick, etc, we need to check for a matching supported type before ejecting or injecting. Also, added checking that the virtual media supports injecting before trying.
Checklist
The HW vendor this change applies to (if applicable)
The HW model number, product name this change applies to (if applicable)
The BMC firmware and/or BIOS versions that this change applies to (if applicable)
What version of tooling - vendor specific or opensource does this change depend on (if applicable)
Description for changelog/release notes